Skip to content

[202012][Accton] Implement as5835-54t api2.0 #8294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: 202012
Choose a base branch
from

Conversation

seanwu-ec
Copy link
Contributor

@seanwu-ec seanwu-ec commented Jul 30, 2021

Why I did it

Support API2.0 on 202012 branch

How I did it

Added needed content for sonic_platform package, AS5835-54X's code is mainly referenced

How to verify it

Built the image and tested it on DUT. The tests include some functional checks and going through some commands on the show program.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

[Accton] Implement AS5835-54T API2.0

A picture of a cute animal (not mandatory but encouraged)

Alt Text

- Fix sfputil read QSFP port fail
- Fix read thermal sensor issue

Signed-off-by: Sean Wu <[email protected]>
- Apply equivalent changes from PR#8276

Signed-off-by: Sean Wu <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Jul 30, 2021

This pull request introduces 4 alerts and fixes 2 when merging 2e3dc6f into 5651977 - view on LGTM.com

new alerts:

  • 3 for Unused import
  • 1 for Variable defined multiple times

fixed alerts:

  • 2 for Variable defined multiple times

Signed-off-by: Sean Wu <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Jul 30, 2021

This pull request fixes 5 alerts when merging 7cefbfe into 5651977 - view on LGTM.com

fixed alerts:

  • 3 for Unused import
  • 2 for Variable defined multiple times

- Fix ValueError while open() with assigning no_buffer
- Fix illegal use of chr()

Signed-off-by: Sean Wu <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Aug 2, 2021

This pull request fixes 5 alerts when merging 6835c98 into 2a41adc - view on LGTM.com

fixed alerts:

  • 3 for Unused import
  • 2 for Variable defined multiple times

@seanwu-ec
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@seanwu-ec seanwu-ec marked this pull request as ready for review August 5, 2021 07:30
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

* correct the wait and timeout mechanism for better CPU usage.
* Fix is_host() API might make OS stuck

Signed-off-by: Sean Wu <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Oct 13, 2021

This pull request fixes 5 alerts when merging c543342 into 4447426 - view on LGTM.com

fixed alerts:

  • 3 for Unused import
  • 2 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Dec 14, 2021

This pull request introduces 1 alert and fixes 5 when merging be55ed4 into 0197855 - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a call

fixed alerts:

  • 3 for Unused import
  • 2 for Variable defined multiple times

@seanwu-ec
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This reverts commit be55ed4.

* Accton has decided to keep 6-levels thermal threshold APIs only to
  Accton's customized SONiC instead of polluting Community SONiC
  code.
@lgtm-com
Copy link

lgtm-com bot commented Jan 24, 2022

This pull request fixes 5 alerts when merging 0b6a9f2 into 3dae536 - view on LGTM.com

fixed alerts:

  • 3 for Unused import
  • 2 for Variable defined multiple times

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants