Skip to content

[buildsystem] install 3rd party debian packages in base OS during build #8151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

stepanblyschak
Copy link
Collaborator

Signed-off-by: Stepan Blyschak [email protected]

Why I did it

To allow installing some 3rd party debian packages during build time.

How I did it

Added a build time parameter INSTALL_THIRD_PARTY_DEBS.

How to verify it

INSTALL_THIRD_PARTY_DEBS="https://some.host/some.deb" make target/sonic-mellanox.bin

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
@@ -262,6 +262,7 @@ $(info "TELEMETRY_WRITABLE" : "$(TELEMETRY_WRITABLE)")
$(info "PDDF_SUPPORT" : "$(PDDF_SUPPORT)")
$(info "MULTIARCH_QEMU_ENVIRON" : "$(MULTIARCH_QEMU_ENVIRON)")
$(info "SONIC_VERSION_CONTROL_COMPONENTS": "$(SONIC_VERSION_CONTROL_COMPONENTS)")
$(info "INSTALL_THIRD_PARTY_DEBS" : "$(INSTALL_THIRD_PARTY_DEBS)")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INSTALL_THIRD_PARTY_DEBS

This new parameter is too general and easy to abuse.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain? If so, is there an alternative to what we are trying to achive?

@stepanblyschak
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft qiluo-msft requested a review from prsunny August 16, 2021 09:55
@liat-grozovik
Copy link
Collaborator

@prsunny kindly reminder. can you also review?

@stepanblyschak stepanblyschak deleted the 3rd_party_debs branch September 23, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants