-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[Barefoot] Enable 'TELEMETRY_WRITABLE' for telemetry container #8012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Barefoot] Enable 'TELEMETRY_WRITABLE' for telemetry container #8012
Conversation
@xumia Could you please take a look? |
@@ -48,6 +48,7 @@ jobs: | |||
docker_syncd_rpc_image: yes | |||
platform_rpc: bfn | |||
swi_image: yes | |||
BUILD_OPTIONS: $(BUILD_OPTIONS) TELEMETRY_WRITABLE=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean as below? the value ${{ parameters.buildOptions }} is replaced in the template compiling process.
BUILD_OPTIONS: ${{ parameters.buildOptions }} TELEMETRY_WRITABLE=y
The variables in jobVariables applying to all job groups can be overridden by the variables in each of the jobGroups.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks, I`ll fix this. So it means that my change wouldn`t work at all?
5551d6b
to
7f57a1a
Compare
@xumia Could you please check my new change? |
telemtry_writable should be consistent across different platform. we cannot enable write only on a particular platform. |
Could we enable telemtry_writable for all platforms? If yes, I will update pull request with needed changes. |
that is not the current plan. the viable solution is to make the telemetry writable as a runtime option, then user can enable it on the fly and no longer a build option. |
Why I did it
For testing
gNMI/gNOI
we need to enable r/w mode for telemetry containerHow I did it
Added
TELEMETRY_WRITABLE=y
option tomake
commandHow to verify it
Build SONiC with command
make TELEMETRY_WRITABLE=y target/sonic-aboot-barefoot.swi
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)