Skip to content

[Barefoot] Enable 'TELEMETRY_WRITABLE' for telemetry container #8012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

YuliiaBashko
Copy link

Why I did it

For testing gNMI/gNOI we need to enable r/w mode for telemetry container

How I did it

Added TELEMETRY_WRITABLE=y option to make command

How to verify it

Build SONiC with command make TELEMETRY_WRITABLE=y target/sonic-aboot-barefoot.swi

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@YuliiaBashko YuliiaBashko requested a review from lguohan as a code owner June 29, 2021 08:30
@YuliiaBashko
Copy link
Author

@xumia Could you please take a look?

@@ -48,6 +48,7 @@ jobs:
docker_syncd_rpc_image: yes
platform_rpc: bfn
swi_image: yes
BUILD_OPTIONS: $(BUILD_OPTIONS) TELEMETRY_WRITABLE=y
Copy link
Collaborator

@xumia xumia Jun 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean as below? the value ${{ parameters.buildOptions }} is replaced in the template compiling process.
BUILD_OPTIONS: ${{ parameters.buildOptions }} TELEMETRY_WRITABLE=y

See https://github.com/Azure/sonic-buildimage/blob/03c6b1bf7c9462a8a2b8a17c8ecfe5e6cc5a77c8/.azure-pipelines/azure-pipelines-build.yml#L30

The variables in jobVariables applying to all job groups can be overridden by the variables in each of the jobGroups.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks, I`ll fix this. So it means that my change wouldn`t work at all?

akokhan
akokhan previously approved these changes Jun 30, 2021
@YuliiaBashko
Copy link
Author

@xumia Could you please check my new change?

@lguohan
Copy link
Collaborator

lguohan commented Aug 10, 2021

telemtry_writable should be consistent across different platform. we cannot enable write only on a particular platform.

@YuliiaBashko
Copy link
Author

telemtry_writable should be consistent across different platform. we cannot enable write only on a particular platform.

Could we enable telemtry_writable for all platforms? If yes, I will update pull request with needed changes.

@lguohan
Copy link
Collaborator

lguohan commented Aug 11, 2021

that is not the current plan. the viable solution is to make the telemetry writable as a runtime option, then user can enable it on the fly and no longer a build option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants