Ensure platform has a chance to override defaults #7525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding your example 2, you should use |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
This provides ability for Platform to override certain defaults specified in the SONiC's rules/config file or via the environment variables. This gives build time & run time flexibility for a vendor platform to scale over build and run time issues
How I did it
Check if platform//rules/config file exists and if so then source it
How to verify it
Two such examples are as follows:
example1:
$(if $ (BUILD_DOCKER_CONFIG),$(BUILD_DOCKER_CONFIG),/etc/docker/interior.daemon.json):/etc/docker/daemon.json:ro
For instance, certain build time docker mounts issues in internal servers can be overcome:
DOCKER_BUILDER_MOUNTS :=
example 2:
DEFAULT_USERNAME := foo
DEFAULT_PASSWORD := bar
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)