[as5835-54x]Set sfp port tx_disable to disable #5672
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Retest please |
1 similar comment
|
Retest please |
|
The PR is too old and it it pytho2.7 file. So close and resend PR. |
|
The PR is too old and get file conflict. So create new PR to handle related fixed code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
Set tx_disable to disable for each boot.
Because CPLD default setting is enable.
- How I did it
Add disable code to accton_as5835_54x_util.py
- How to verify it
Make sure tx_disable offset is enable.
./accton_as5835_54x_util.py clean
./accton_as5835_54x_util.py install
root@sonic:/usr/local/bin# cat /sys/bus/i2c/devices/3-0061/module_tx_disable_1
0
root@sonic:/usr/local/bin# cat /sys/bus/i2c/devices/3-0061/module_tx_disable_1
0
.....
Other sfp ports tx_dis sysfs are 0.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)