[device/accton]as4630-54pe, two i2c adaptors might be installed not in presumed order. #5393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a check on it and follow up. Signed-off-by: roy_lee <[email protected]>
|
This pull request introduces 4 alerts and fixes 2 when merging c86fb9d into ae9a86f - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: roy_lee <[email protected]>
|
This pull request fixes 2 alerts when merging 6dc6125 into e3f8159 - view on LGTM.com fixed alerts:
|
|
Retest this please |
|
The solution is changed. Problem will be fixed on later PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check on i2c bus topology and follow up.
Signed-off-by: roy_lee [email protected]
- Why I did it
Sometimes, DUT boot-up with i2c dev error message.
- How I did it
Check i2c buses and use the correct one to install devices.
- How to verify it
No error at a long time reboot test.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
As the code diff.