[ssh limit] add infrastructure to set per user login limit #5338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifying per user login limit via USER_LOGIN_LIMIT build argument. When not specified, the user login is unlimited by default. Signed-off-by: Ying Xie <[email protected]>
yxieca
changed the title
jleveque
reviewed
Sep 9, 2020
| @@ -161,3 +160,6 @@ SONIC_ENABLE_IMAGE_SIGNATURE ?= n | |||
|
|
|||
| # ENABLE_SYNCHRONOUS_MODE - enable synchronous mode between orchagent and syncd | |||
| ENABLE_SYNCHRONOUS_MODE = n | |||
|
|
|||
| # Default SSH per user login limit (unlimited) | |||
| DEFAULT_USER_LOGIN_LIMIT = 0 | |||
There was a problem hiding this comment.
Is this tested and working? According to the man page, it appears that -1 is the numerical representation of unlimited:
All items support the values -1, unlimited or infinity indicating no limit, except for priority and nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
We have an use case to limit max number of login per user.
- How I did it
Specifying per user login limit via USER_LOGIN_LIMIT build argument.
When not specified, the per user login is unlimited by default.
Signed-off-by: Ying Xie [email protected]
- How to verify it
Verified in 2 aspects:
- Which release branch to backport (provide reason below if selected)