Pddf_support_dell_platforms: Add PDDF support for s52xx dell platforms. #18849

arun1355492 · 2024-05-02T09:16:28Z

Why I did it

Add PDDF support for the dell s52xx platforms.

How I did it

Add PDDF configuration files, scripts and python files.

How to verify it

To switch to PDDF mode run the below command and wait for the system to be ready.
pddf_util.py -d switch-pddf

Run the PDDF commnads
systemctl | grep -i pddf
pddf_fanutil direction
pddf_fanutil getspeed
pddf_fanutil numfans
pddf_fanutil status
pddf_psuutil mfrinfo
pddf_psuutil numpsus
pddf_psuutil seninfo
pddf_psuutil status
pddf_thermalutil gettemp
pddf_thermalutil numthermals
pddf_ledutil getstatusled SYS_LED
pddf_ledutil getstatusled FAN_LED
pddf_ledutil getstatusled FANTRAY1_LED
pddf_ledutil getstatusled FANTRAY2_LED
pddf_ledutil getstatusled FANTRAY3_LED
pddf_ledutil getstatusled FANTRAY4_LED

Note: To switch back to non PDDF mode check help on pddf_util.py -help

202305

Unit Test results:
s5232f_pddf_logs.txt
s5248f_pddf_logs.txt
s5296_pddf_logs.txt
s5212f_pddf_logs.txt
s5224f_pddf_logs.txt

A picture of a cute animal (not mandatory but encouraged)

linux-foundation-easycla · 2024-05-02T09:16:32Z

The committers listed above are authorized under a signed CLA.

✅ login: arun1355492 / name: Arun Akula (7629d0f, 82c8fe3, 467f3a3, 2a03d84, 32aea9f, 1626173, a0d53f5, 08e2c03, 64c230b)

arun1355492 · 2024-05-07T18:39:19Z

@srideepDell Please review the PR.

jeff-yin · 2024-05-08T04:07:35Z

@lguohan @zhangyanzhao -- please assign @srideepDell , @rvasanthm , @thaj-deen , @vpsubramaniam , @arunlk-dell to review this Dell platform PR. Also, @FuzailBrcm and @leeprecy from Broadcom, who have expertise in PDDF.

Thanks!

lguohan · 2024-05-12T08:40:23Z

@jeff-yin , no need to assign. please have reviewer to sign off, then we can merge.

aravindmani-1

From the UT logs, Hardware Revision is displayed as "N/A". Could you please check it?.
Also, please attach sonic-mgmt test results.

FuzailBrcm · 2024-07-13T04:07:00Z

@leeprecy @geans-pin
Please review these changes

aravindmani-1

could you please use https://github.com/sonic-net/sonic-buildimage/blob/master/platform/broadcom/sonic-platform-modules-dell/common/ipmihelper.py instead of redefining ipmihelper in each platform.

aravindmani-1 · 2024-07-13T16:12:38Z

platform/broadcom/sonic-platform-modules-dell/s5212f/scripts/pddf_pre_driver_install.sh

why switch_board_sfp/ switch_board_qsfp is not deinitialized like it is done for other platforms?.

They are done as part of s52xxf_platform.sh under deinitialized.

aravindmani-1 · 2024-07-13T16:16:37Z

platform/broadcom/sonic-platform-modules-dell/s5232f/scripts/platform-modules-s5232f.sh

media_down is not used in platform init file. Check the same for all the platform init files.

Implemented changes similar to other platform init files.

aravindmani-1 · 2024-07-13T16:19:54Z

platform/broadcom/sonic-platform-modules-dell/s5248f/scripts/s5248f_platform.sh

@@ -128,8 +128,7 @@ switch_board_led_default() {
 install_python_api_package() {
    device="/usr/share/sonic/device"
    platform=$(/usr/local/bin/sonic-cfggen -H -v DEVICE_METADATA.localhost.platform)
-
-    pip3 install $device/$platform/sonic_platform-1.0-py3-none-any.whl
+    rv=$(pip3 install $device/$platform/sonic_platform-1.0-py3-none-any.whl --force-reinstall -q --root-user-action=ignore)


why --force-reinstall option and --root-user-action rules added here?.

return value rv is unused here.

rohinikumart · 2024-07-15T10:16:23Z

platform/broadcom/sonic-platform-modules-dell/s5232f/pddf/sonic_platform/chassis.py

@@ -0,0 +1,125 @@
+#!/usr/bin/env python


should it be python or python3 ?

Should be Python, ensures that the script is executed with the Python interpreter found in the user’s environment, regardless of where Python is installed on the system.

rohinikumart · 2024-07-15T10:37:59Z

platform/broadcom/sonic-platform-modules-dell/s5296f/scripts/pddf_switch_svc.py

+
+    return True
+
+def main():


I see main is dummy. is that fine ?

Fine and serving as a placeholder.

rohinikumart · 2024-07-15T11:44:45Z

platform/broadcom/sonic-platform-modules-dell/debian/rules

@@ -31,40 +31,75 @@ override_dh_auto_build:
 			python3 -m build --wheel --no-isolation --outdir $(MOD_SRC_DIR)/$${mod}/modules; \
 			cd $(MOD_SRC_DIR); \
 		elif [ $$mod = "z9264f" ]; then \
-		        cp $(COMMON_DIR)/dell_fpga_ocores.c $(MOD_SRC_DIR)/$${mod}/modules/dell_z9264f_fpga_ocores.c; \


What is the change here ?

What is the change here ?

No change.

can you remove this from diff then ?

…32f and s5248f dell Platfroms

…df mode

arun1355492 · 2024-07-31T23:32:44Z

could you please use https://github.com/sonic-net/sonic-buildimage/blob/master/platform/broadcom/sonic-platform-modules-dell/common/ipmihelper.py instead of redefining ipmihelper in each platform.

Changed to use from the common folder.

…own comments

arun1355492 · 2024-09-30T19:51:47Z

From the UT logs, Hardware Revision is displayed as "N/A". Could you please check it?. Also, please attach sonic-mgmt test results.

I have ran sonic-mgmt test for the dell platforms in pddf mode and added required function as part of sonic-mgmt test. Also addressed review comments.

Attaching latest UT logs and sonic-mgmt test case report. Some of the test cases are failed due to name mismatch from the platform.json which will resolved in the future enhancements whenever newer pddf updates.

Platforms s5232f and s5248f does not have platform.json. s5248f will have platform.json from https://github.com/sonic-net/sonic-buildimage/pull/20287/files and s5232f will have platform.json in future updates.

s5212f_logs.txt
s5212f_pddf_logs.txt
s5224f_logs.txt
s5224f_pddf_logs.txt
s5232f_logs.txt
s5232f_pddf_logs.txt
s5248f_logs.txt
s5248f_pddf_logs.txt
s5296f_logs.txt
s5296f_pddf_logs.txt
sonic_mgmt_test_report.xlsx

jeff-yin · 2024-10-09T17:36:43Z

/azpw ms_conflict

rohinikumart · 2024-12-20T09:34:44Z

platform/broadcom/sonic-platform-modules-dell/s5296f/scripts/pddf_pre_driver_install.sh

@@ -0,0 +1,16 @@
+#!/bin/bash
+sys_eeprom "delete_device"


following four are not defined in the script

These functions are not used in pddf mode, hence removed from the script.

mssonicbld · 2025-01-23T19:47:48Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2025-01-23T19:48:01Z

Azure Pipelines successfully started running 1 pipeline(s).

rohinikumart · 2025-01-24T06:47:37Z

device/dell/x86_64-dellemc_s5248f_c3538-r0/pddf/pddf-device.json

+					{ "attr_name":"psu_i_in", "bmc_cmd":"ipmitool sensor reading PSU2_In_amp", "raw":"0", "field_name" : "PSU2_In_amp", "separator":"|", "field_pos":"2", "mult":"1000"},
+					{ "attr_name":"psu_fan1_speed_rpm", "bmc_cmd":"ipmitool sensor reading PSU2_rpm", "raw":"0", "field_name" : "PSU2_rpm", "separator":"|", "field_pos":"2", "mult":"1"},
+					{ "attr_name":"psu_temp1_input", "bmc_cmd":"ipmitool sensor reading PSU2_temp", "raw":"0", "field_name" : "PSU2_temp", "separator":"|", "field_pos":"2", "mult":"1000"},
+					{ "attr_name":"psu_fan_dir", "bmc_cmd":"ipmitool raw 0x3a 0x3 0x14 0x0b", "raw": "1", "type":"mask", "mask":"0x1"}


platform api test cases expects psu_temp1_high_threshold also here. I see it is not added to any platform

In platforms api tests, when PSU sensors read Temperature 30.0 of PSU 0 is over the threshold 0.0, Temperature 0.0 of PSU 1 is over the threshold 0.0.
As the thresholds are not configured and set to 0. In future when thresholds are configured, need to update expected values.

threshold 0.0 is returned from platform api tests when it is not able to find psu_temp1_high_threshold. You need to add psu_temp1_high_threshold to pddf-device.json with approriate bmc commad to get it .
I added it as below for s5448 .
{ "attr_name":"psu_temp1_high_threshold", "bmc_cmd":"ipmitool sensor", "raw":"0", "field_name":"PSU1_AF_temp", "separator":"|", "field_pos":"9", "mult":"1000"}

Those are added as part of temperature sensor with different attributes names in the platforms.
TEMP7":
{
"dev_info": { "device_type":"TEMP_SENSOR"},
"dev_attr": { "display_name":"PSU1 Airflow Sensor"},
"bmc": {
"ipmitool" : {
"attr_list":
[
{ "attr_name":"temp1_high_crit_threshold", "bmc_cmd":"ipmitool raw 0x04 0x27 0x07 | cut -d ' ' -f 7", "raw":"1", "type":"raw"},
{ "attr_name":"temp1_high_threshold", "bmc_cmd":"ipmitool raw 0x04 0x27 0x07 | cut -d ' ' -f 6", "raw":"1", "type":"raw"},
{ "attr_name":"temp1_input", "bmc_cmd":"ipmitool sensor reading PSU1_AF_temp", "raw":"0", "field_name" : "PSU1_AF_temp", "separator":"|", "field_pos":"2", "mult":"1"},
{ "attr_name":"temp1_low_threshold", "bmc_cmd":"ipmitool raw 0x04 0x27 0x07 | cut -d ' ' -f 4", "raw":"1", "type":"raw"}
]
}
}
},

psu_temp1_high_threshold is to be added for all PSUs.

Yes, psu_temp1_high_threshold already added for all the PSU's in the platforms. In the current platform number of temperature sensor are 8 and PSU temperature sensors are TEMP7 and TEMP8.

arun1355492 · 2025-04-25T04:13:54Z

@lguohan could you please approve the PR? It has already been approved by three reviewers, but it still shows that a review is required from a reviewer with write access. It's been pending for a long time.

tomvil · 2025-05-23T07:57:52Z

Hey @arun1355492,

I have tested these changes on my 5248F-25G switch and noticed that after enabling PDDF pddf_util.py switch-pddf and rebooting the device it starts to flood the following warning in syslog/dmesg:

get_module_presence: do_get function fails for xcvr_present attribute. ret -1

And I'm unable to get any information about DACs/SFPs. Without these changes everything is working fine, tested with 202405 branch.

EDIT: Just rebuilt with latest 202405, I still see those warnings, but they stop after some time 🤷‍♂️ Will play around a bit more.

arun1355492 · 2025-05-27T10:09:24Z

Hey @arun1355492,

I have tested these changes on my 5248F-25G switch and noticed that after enabling PDDF pddf_util.py switch-pddf and rebooting the device it starts to flood the following warning in syslog/dmesg:

get_module_presence: do_get function fails for xcvr_present attribute. ret -1

And I'm unable to get any information about DACs/SFPs. Without these changes everything is working fine, tested with 202405 branch.

EDIT: Just rebuilt with latest 202405, I still see those warnings, but they stop after some time 🤷‍♂️ Will play around a bit more.

let me check the issue on 5248F-25G platform.

tomvil · 2025-06-02T08:48:29Z

Also we noticed that show platform psustatus doesn't always work after enabling pddf, while psuutil status works:

# show platform psustatus
PSU    Model    Serial    HW Rev    Voltage (V)    Current (A)    Power (W)    Status       LED
-----  -------  --------  --------  -------------  -------------  -----------  -----------  -----
PSU 1  N/A      N/A       N/A       N/A            N/A            N/A          NOT PRESENT
PSU 2  N/A      N/A       N/A       N/A            N/A            N/A          NOT PRESENT

we're testing 5248F platform here as well

arun1355492 requested a review from lguohan as a code owner May 2, 2024 09:16

arun1355492 marked this pull request as draft May 2, 2024 09:17

arun1355492 changed the title ~~[DELL] pddf_support_dell_platforms: Add PDDF support for s5212f, s5224f, s5232f and s5248f dell platforms.~~ Pddf_support_dell_platforms: Add PDDF support for s5212f, s5224f, s5232f and s5248f dell platforms. May 2, 2024

arun1355492 changed the title ~~Pddf_support_dell_platforms: Add PDDF support for s5212f, s5224f, s5232f and s5248f dell platforms.~~ Pddf_support_dell_platforms: Add PDDF support for s52xx dell platforms. May 4, 2024

arun1355492 marked this pull request as ready for review May 7, 2024 18:39

lguohan added the Platform: DellEMC label May 13, 2024

srideepDell approved these changes May 23, 2024

View reviewed changes

aravindmani-1 reviewed Jul 13, 2024

View reviewed changes

aravindmani-1 suggested changes Jul 13, 2024

View reviewed changes

aravindmani-1 reviewed Jul 13, 2024

View reviewed changes

rohinikumart reviewed Jul 15, 2024

View reviewed changes

arun1355492 force-pushed the pddf_support_dell_platforms branch from e2939e9 to b1ef642 Compare July 23, 2024 19:40

arun1355492 requested review from StormLiangMS, qiluo-msft and xumia as code owners July 26, 2024 22:29

arun1355492 added 4 commits July 26, 2024 15:43

pddf_support_dell_platforms: Add PDDF support for s5212f, s5224f, s52…

7629d0f

…32f and s5248f dell Platfroms

PDDF support for s5296f platform and fix error for reboot-cause in pd…

467f3a3

…df mode

reboot-cause error fix in pddf mode

32aea9f

ipmihelper will be used from dell common folder

1626173

arun1355492 force-pushed the pddf_support_dell_platforms branch from dd59ad1 to 1626173 Compare July 26, 2024 22:44

Implemented review comments

a0d53f5

arun1355492 added 2 commits August 4, 2024 23:35

Formated the pddf json file for s5296f platform and addressed media_d…

64c230b

…own comments

addressed media_down review comments

2a03d84

jeff-yin mentioned this pull request Aug 28, 2024

Breakout not working on Dell S5248F #19995

Open

UT logs and sonic-mgmt test results

08e2c03

aravindmani-1 approved these changes Oct 1, 2024

View reviewed changes

rohinikumart approved these changes Oct 5, 2024

View reviewed changes

jeff-yin mentioned this pull request Oct 9, 2024

Sonic mgmt test cases failed due to unable to get expected values from platform.json file for s5232f platform. #20446

Open

rohinikumart reviewed Dec 20, 2024

View reviewed changes

Removed unused functions

82c8fe3

rohinikumart reviewed Jan 24, 2025

View reviewed changes

rohinikumart approved these changes Jan 30, 2025

View reviewed changes

Pddf_support_dell_platforms: Add PDDF support for s52xx dell platforms. #18849

Are you sure you want to change the base?

Pddf_support_dell_platforms: Add PDDF support for s52xx dell platforms. #18849

Uh oh!

Conversation

arun1355492 commented May 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I did it

How I did it

How to verify it

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

linux-foundation-easycla bot commented May 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arun1355492 commented May 7, 2024

Uh oh!

jeff-yin commented May 8, 2024

Uh oh!

lguohan commented May 12, 2024

Uh oh!

aravindmani-1 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FuzailBrcm commented Jul 13, 2024

Uh oh!

aravindmani-1 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aravindmani-1 Jul 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aravindmani-1 Jul 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rohinikumart Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arun1355492 commented Jul 31, 2024

Uh oh!

arun1355492 commented Sep 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jeff-yin commented Oct 9, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Jan 23, 2025

Uh oh!

azure-pipelines bot commented Jan 23, 2025

Uh oh!

Choose a reason for hiding this comment

arun1355492 commented May 2, 2024 •

edited

Loading

linux-foundation-easycla bot commented May 2, 2024 •

edited

Loading

aravindmani-1 left a comment •

edited

Loading

aravindmani-1 Jul 13, 2024 •

edited

Loading

aravindmani-1 Jul 13, 2024 •

edited

Loading

rohinikumart Jul 15, 2024 •

edited

Loading

arun1355492 commented Sep 30, 2024 •

edited

Loading

arun1355492 Jan 24, 2025 •

edited

Loading

tomvil commented May 23, 2025 •

edited

Loading

tomvil commented Jun 2, 2025 •

edited

Loading