[202305][graceful reboot] Rename the platform_reboot to the pre_reboot_hook, remove the sysfs power cycle #18250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emove sysfs power cycle, and Debina reboot Signed-off-by: vadymhlushko-mlnx <[email protected]>
…r all mellanox devices Signed-off-by: vadymhlushko-mlnx <[email protected]>
|
@prgeor Can you please also review this one? |
zhangyanzhao
added
Approved for 202311 Branch
and removed
Request for 202305 Branch
Approved for 202311 Branch
labels
prgeor
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
@vadymhlushko-mlnx appreciate if you could point to the master PR in the description
|
|
@prgeor could you please help to merge |
@liat-grozovik can you merge. |
|
@liat-grozovik could you please merge |
|
@StormLiangMS , Can you please assist with merge ? |
|
@StormLiangMS @yxieca can you merge |
|
@StormLiangMS @yxieca can you please merge |
|
hi @bingwang-ms could you help to comment on this? Is this needed for 202305? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPENDS ON: [202305][graceful reboot] Add the pre_reboot_hook script execution, add the watchdog arm before the reboot
Why I did it
Add support for the
graceful rebootinstead of thesysfs power cycleto avoid filesystem corruptionWork item tracking
How I did it
Rename the
platform_rebootscript to thepre_reboot_hook.Remove the sysfs power cycle function, from now on the Debian reboot (
/sbin/reboot) will be executed instead of the sysfs power cycle.How to verify it
show log -fandjournalctl -p debug -frebootcommand from the switch CLIWhich release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)