[Arista][pmem] create persistent memory on RAM for safe warm-reboot on arista_7060_cx32s #18080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vaibhav-dahiya <[email protected]>
prgeor
changed the title
prgeor
reviewed
Feb 9, 2024
files/initramfs-tools/union-mount.j2
Outdated
| @@ -38,6 +39,9 @@ for x in $(cat /proc/cmdline); do | |||
| logs_inram=on) | |||
| logs_inram=true | |||
| ;; | |||
| mount_pmem=on) | |||
There was a problem hiding this comment.
@vdahiya12 adding memmap=* is sufficient.
prgeor
reviewed
Feb 9, 2024
files/Aboot/boot0.j2
Outdated
| @@ -494,6 +494,8 @@ write_platform_specific_cmdline() { | |||
| if in_array "$sid" "Upperlake" "UpperlakeES" "UpperlakeElite"; then | |||
| aboot_machine=arista_7060_cx32s | |||
| flash_size=3700 | |||
| cmdline_add memmap=512M!4G | |||
| cmdline_add mount_pmem=on | |||
There was a problem hiding this comment.
@vdahiya12 don't need this new parameter mount_pmem, see below comment
Signed-off-by: vaibhav-dahiya <[email protected]>
|
@vdahiya12 please add more description,
|
Signed-off-by: vaibhav-dahiya <[email protected]>
Signed-off-by: vaibhav-dahiya <[email protected]>
Signed-off-by: vaibhav-dahiya <[email protected]>
vdahiya12
changed the title
vdahiya12
changed the title
saiarcot895
reviewed
May 8, 2024
| @@ -235,6 +241,19 @@ else | |||
| fi | |||
| fi | |||
|
|
|||
| # check the fstype of pmem if not ext4 fformat and mount | |||
There was a problem hiding this comment.
Typo and run-on sentence here.
saiarcot895
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does the following things for x86_64-arista_7060_cx32s
Why I did it
Work item tracking
How I did it
How to verify it
tested by custom building and deploying the changes on a arista_7060_cx32s DUT/testbed
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)