Skip to content

Start fabric mgr daemon in swss container. #17473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2024
Merged

Start fabric mgr daemon in swss container. #17473

merged 1 commit into from
Feb 8, 2024

Conversation

jfeng-arista
Copy link
Contributor

Why I did it

The fabricmgr daemon started in vs environment for testing from #16791, we now start the daemon in product code.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Start fabric mgr daemon in swss container .

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@jfeng-arista
Copy link
Contributor Author

/Azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista jfeng-arista mentioned this pull request Dec 11, 2023
Merged
7 tasks
@jfeng-arista
Copy link
Contributor Author

the failure seems not related to the change

/Azpw run Azure.sonic-buildimage

@jfeng-arista
Copy link
Contributor Author

/Azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

/Azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfeng-arista
Copy link
Contributor Author

2023-12-13T21:09:29.8376752Z Test plan id: 657a0283cfacd86e78e3e907, status: EXECUTING, progress: 91.67%, elapsed: 5169 seconds
2023-12-13T21:09:29.8377841Z Operation failed with exception: Exception('Test plan id: 657a0283cfacd86e78e3e907, status: FAILED, result: FAILED, Elapsed 5229 seconds. Check https://elastictest.org/scheduler/testplan/657a0283cfacd86e78e3e907 for test plan status')
2023-12-13T21:09:29.8580108Z ##[error]Bash exited with code '3'.
2023-12-13T21:09:29.8610465Z ##[section]Finishing: Run test

failed as abvoe, not sure if this could related to my change as it is in t0.

I will retirgger the pipline tomorrow

@jfeng-arista
Copy link
Contributor Author

/Azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@judyjoseph judyjoseph requested a review from arlakshm December 14, 2023 21:41
arlakshm pushed a commit to sonic-net/sonic-mgmt that referenced this pull request Jan 24, 2024
@jfeng-arista
[chassis][voq]Add mgmt test for testing fabric link isolation cli com…
0b3225e 
…mands. (#10994)

Summary: Add mgmt test for testing fabric link isolation cli commands.

This change adds a test for the fabric link isolation command.
The test iterates over the fabric links on a linecard. It isolates and unisolates fabric links. Each time the state of the link is changed the state is checked in both CONFIG_DB and APPL_DB. The values in CONFIG_DB are updated by the fabric CLI commands and the values in APPL_DB are updated by the fabric manager daemon. The test check if the 2 major part work as expected.

need to wait sonic-net/sonic-buildimage#17473

Signed-off-by: Jie Feng <[email protected]>
@arlakshm
Copy link
Contributor

@lguohan, can you help merge this PR

@rlhui rlhui merged commit 5a20589 into sonic-net:master Feb 8, 2024
sonic-otn pushed a commit to Weitang-Zheng/sonic-buildimage that referenced this pull request Mar 11, 2024
@jfeng-arista @sonic-otn
Start fabric mgr daemon in swss container. (sonic-net#17473)
4b312eb 
The fabricmgr daemon started in vs environment for testing from sonic-net#16791, we now start the daemon in product code.
saksarav-nokia pushed a commit to saksarav-nokia/sonic-buildimage that referenced this pull request Mar 12, 2024
@jfeng-arista @saksarav-nokia
Start fabric mgr daemon in swss container. (sonic-net#17473)
4420275 
The fabricmgr daemon started in vs environment for testing from sonic-net#16791, we now start the daemon in product code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arlakshm arlakshm arlakshm approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees

@jfeng-arista jfeng-arista

Labels
None yet
Projects
SONiC Chassis
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jfeng-arista @mssonicbld @arlakshm @rlhui