Delete stretch and jessie references #17075
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluecmd
force-pushed
the
pr-remove-old-debians
branch
from
3bbe93a to
423c117
Compare
bluecmd
changed the title
saiarcot895
reviewed
Nov 2, 2023
saiarcot895
reviewed
Nov 2, 2023
Remove the end-of-life'd Debian distributions. Replace all legacy references with bullseye to push the bar to modern distributions. Signed-off-by: Christian Svensson <[email protected]>
- Change base of docker-sonic-p4 to bullseye base - Remove fallback case not needed for dists later than Jessie Signed-off-by: Christian Svensson <[email protected]>
bluecmd
force-pushed
the
pr-remove-old-debians
branch
from
78339a9 to
b236f50
Compare
|
@saiarcot895 @lguohan Any more feedback? Or do you think this can be merged? |
saiarcot895
approved these changes
Nov 7, 2023
|
Ping @lguohan! Any chance to merge this? Not sure what the |
|
@bluecmd Can you update your PR for the current code? Changes for Bookworm got merged in recently. |
Since there was 4 weeks of no comments after several pings - I'm not interested in doing that without a promise that this PR will be merged. I would hate to put in a new weekends worth of work to test it all and not have the PR merged and no communicated reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the end-of-life'd Debian distributions. Replace all legacy references with bullseye to push the bar to modern distributions.
Why I did it
Pay some technical debt by cleaning up old references that should not be used for future releases.
How I did it
Mostly
git grepand similar forjessieandstretch.How to verify it
If it builds, it works.
Which release branch to backport (provide reason below if selected)
None, this is only for new releases.
Tested branch (Please provide the tested image version)
N/A
Description for the changelog
For releases 2024 and later the use of Jessie and Stretch are no longer supported.
Link to config_db schema for YANG module changes
N/A
A picture of a cute animal (not mandatory but encouraged)