Skip to content

[Mellanox] Fix uninitialized variable on module plug event #17011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fastiuk
Copy link
Contributor

@fastiuk fastiuk commented Oct 25, 2023

Why I did it

To fix uninitialized variable

How I did it

Add initial value

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

A picture of a cute animal (it is my cat Finn)

PXL_20230413_140941610 PORTRAIT

@fastiuk fastiuk requested a review from lguohan as a code owner October 25, 2023 16:09
@fastiuk fastiuk changed the title Fix uninitialized variable on module plug event [Nvidia] Fix uninitialized variable on module plug event Oct 25, 2023
@fastiuk fastiuk self-assigned this Oct 25, 2023
@fastiuk
Copy link
Contributor Author

fastiuk commented Dec 1, 2023

@lguohan could you please review?

@liat-grozovik liat-grozovik changed the title [Nvidia] Fix uninitialized variable on module plug event [Mellanox] Fix uninitialized variable on module plug event Dec 25, 2023
@liat-grozovik
Copy link
Collaborator

@fastiuk to which branches this fix should go in? just master?

@fastiuk
Copy link
Contributor Author

fastiuk commented Jan 10, 2024

@fastiuk to which branches this fix should go in? just master?

That bug with us since day 0.
starting from v201911, when that file was created.
Since that, I assume master is enough

@fastiuk fastiuk force-pushed the dev-revert-port-module-plug-event branch from e908759 to c7e1128 Compare January 10, 2024 20:36
@fastiuk fastiuk force-pushed the dev-revert-port-module-plug-event branch from c7e1128 to da8021b Compare January 10, 2024 20:47
@fastiuk
Copy link
Contributor Author

fastiuk commented Jan 29, 2024

@prgeor could you please review this fix? Thanks

@liat-grozovik liat-grozovik merged commit 2f35079 into sonic-net:master Feb 5, 2024
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Feb 16, 2024
…#17011)

- Why I did it
To fix uninitialized variable

- How I did it
Add initial value

Signed-off-by: Yevhen Fastiuk <[email protected]>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #18114

mssonicbld pushed a commit that referenced this pull request Feb 17, 2024
- Why I did it
To fix uninitialized variable

- How I did it
Add initial value

Signed-off-by: Yevhen Fastiuk <[email protected]>
sonic-otn pushed a commit to Weitang-Zheng/sonic-buildimage that referenced this pull request Mar 11, 2024
…#17011)

- Why I did it
To fix uninitialized variable

- How I did it
Add initial value

Signed-off-by: Yevhen Fastiuk <[email protected]>
saksarav-nokia pushed a commit to saksarav-nokia/sonic-buildimage that referenced this pull request Mar 12, 2024
…#17011)

- Why I did it
To fix uninitialized variable

- How I did it
Add initial value

Signed-off-by: Yevhen Fastiuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants