Skip to content

[Ufispace][PDDF] Add PDDF support on S9180-32X #16529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

cytsai0409
Copy link
Contributor

Why I did it

Add PDDF support on Ufispace S9180-32X with Barefoot ASIC.

Based on #14909, this PR fixed the race issue between bfnsdk_20221130_sai_1.11.0_deb11.deb and bfnplatform-ufispace_1.0.0_amd64.deb by creating new folder under /opt/bfn/install_x1_tofino and /opt/bfn/install_x2_tofino and putting our files there. This way the files in bfnsdk_20221130_sai_1.11.0_deb11.deb are not affected. For detail logs please see here #14909 (comment).

We also stress building the sonic images with multiple build process (SONIC_CONFIG_BUILD_JOBS=8) for weeks and did not see similar issue.

Note that there are only two files changed from #14909:

  1. bfnplatform-ufispace_1.0.0_amd64.deb is updated as described above.
  2. Add PDDF_PLATFORM_MODULE_SYM dependency rule in platform-modules-ufispace.mk as PR 16302

Other files remained the same as #14909.

How I did it

Add PDDF configuration files, scripts and python files

How to verify it

Run pddf commands and show commands.

root@sonic:~# pddf_psuutil status
PSU    Status
-----  --------
PSU1   OK
PSU2   OK
root@sonic:~# pddf_thermalutil gettemp
                Temp Sensor     Value
--------------  --------------  -------
Temp_CPU_BOARD  tmp75-i2c-0-4f  temp1    +36.7 C (crit = +70.0 C)
Temp_BMC        temp1    +33.0 C (crit = +65.0 C)
Temp_MAC        temp1    +52.0 C (crit = +95.0 C)
Temp_MAC_Front  temp1    +35.0 C (crit = +65.0 C)
Temp_MAC_Rear   temp1    +37.0 C (crit = +65.0 C)
Temp_PSU1_AMB   temp1    +39.0 C (crit = +60.0 C)
Temp_PSU1_HS    temp1    +42.0 C (crit = +95.0 C)
Temp_PSU2_AMB   temp1    +42.0 C (crit = +60.0 C)
Temp_PSU2_HS    temp1    +39.0 C (crit = +95.0 C)
root@sonic:~# pddf_fanutil status
FAN         Status
----------  --------
Fantray1_1  OK
Fantray1_2  OK
Fantray2_1  OK
Fantray2_2  OK
Fantray3_1  OK
Fantray3_2  OK
Fantray4_1  OK
Fantray4_2  OK

root@sonic:~# pddf_ledutil getstatusled SYS_LED
green

root@sonic:~# show interfaces transceiver presence
Port         Presence
-----------  -----------
Ethernet0    Present
Ethernet4    Not present
Ethernet8    Present
Ethernet12   Not present
Ethernet16   Present
Ethernet20   Not present
Ethernet24   Not present
Ethernet28   Not present
Ethernet32   Not present
Ethernet36   Not present
Ethernet40   Not present
Ethernet44   Not present
Ethernet48   Not present
Ethernet52   Not present
Ethernet56   Not present
Ethernet60   Not present
Ethernet64   Not present
Ethernet68   Not present
Ethernet72   Not present
Ethernet76   Not present
Ethernet80   Not present
Ethernet84   Not present
Ethernet88   Not present
Ethernet92   Not present
Ethernet96   Not present
Ethernet100  Not present
Ethernet104  Not present
Ethernet108  Not present
Ethernet112  Not present
Ethernet116  Not present
Ethernet120  Not present
Ethernet124  Not present
Ethernet128  Present
Ethernet129  Present
root@sonic:~# show platform fan
  Drawer    LED         FAN    Speed    Direction    Presence    Status          Timestamp
--------  -----  ----------  -------  -----------  ----------  --------  -----------------
Fantray1  green  Fantray1_1      49%       intake     Present        OK  20230502 02:11:59
Fantray1  green  Fantray1_2      50%       intake     Present        OK  20230502 02:11:59
Fantray2  green  Fantray2_1      50%       intake     Present        OK  20230502 02:11:59
Fantray2  green  Fantray2_2      50%       intake     Present        OK  20230502 02:11:59
Fantray3  green  Fantray3_1      49%       intake     Present        OK  20230502 02:11:59
Fantray3  green  Fantray3_2      51%       intake     Present        OK  20230502 02:11:59
Fantray4  green  Fantray4_1      49%       intake     Present        OK  20230502 02:11:59
Fantray4  green  Fantray4_2      51%       intake     Present        OK  20230502 02:11:59
     N/A    N/A   PSU1_FAN1      29%       intake     Present        OK  20230502 02:11:59
     N/A    N/A   PSU2_FAN1      27%       intake     Present        OK  20230502 02:11:59

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Tested branch (Please provide the tested image version)

  • master

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@cytsai0409 cytsai0409 requested a review from lguohan as a code owner September 13, 2023 01:13
@cytsai0409
Copy link
Contributor Author

@FuzailBrcm @liushilongbuaa pls help review, thanks

@liushilongbuaa
Copy link
Contributor

Hi @cytsai0409 , I see opt/bfn/install_x2_tofino opt/bfn/install_x1_tofino are same. They have the same files the same md5sum. But in bfnsdk package there are other folders and one entry soft link. I wonder if bfnplatform package covers all scenario?

find bfnsdk/ | grep '/opt/bfn/install[a-z_0-9]*$'
bfnsdk/opt/bfn/install_x2_tofino
bfnsdk/opt/bfn/install_y2_tofino2
bfnsdk/opt/bfn/install_y1_tofino2
bfnsdk/opt/bfn/install_y2_profile
bfnsdk/opt/bfn/install_x1_profile
bfnsdk/opt/bfn/install_x1_tofino
bfnsdk/opt/bfn/install_x6_profile
bfnsdk/opt/bfn/install_x6_tofino
bfnsdk/opt/bfn/install
bfnsdk/opt/bfn/install_x2_profile
bfnsdk/opt/bfn/install_y1_profile

@cytsai0409
Copy link
Contributor Author

Hi, @liushilongbuaa
No. Our bfnplatform package does not cover all scenario. So far, our device is only equipped with tofino ASIC. According to barefoot SDE document we only need to create new folders under install_x1_tofino and install_x2_tofino for tofino ASIC. Thanks.

Copy link
Contributor

@liushilongbuaa liushilongbuaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ufispace package LGTM.

@cytsai0409
Copy link
Contributor Author

@FuzailBrcm pls help review the pddf code changes. The only difference from #14909 in pddf is adding PDDF_PLATFORM_MODULE_SYM dependency rule in platform-modules-ufispace.mk as #16302 . Tks.

Copy link
Contributor

@FuzailBrcm FuzailBrcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I provided one comment. It can be taken care of later too. Marking it approve.

@@ -0,0 +1,9 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value for most of the fields is 'false'. You dont need to mention each one separately. Only this would have sufficed.

{
"skip_ledd": "true"
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we list all daemons intentionally to make all things clear to us and easy to configure by switching true/false without remembering the "skip_damon_name" naming. Still appreciate you suggestion here.

@cytsai0409
Copy link
Contributor Author

@yxieca please help merge, thanks.

1 similar comment
@cytsai0409
Copy link
Contributor Author

@yxieca please help merge, thanks.

@lguohan lguohan added the device label Sep 23, 2023
@lguohan
Copy link
Collaborator

lguohan commented Sep 23, 2023

please retest, make sure the build is passing

@cytsai0409
Copy link
Contributor Author

Ok, retest is ongoing. Tks.

@cytsai0409
Copy link
Contributor Author

@lguohan I sync code from master branch and run retest but still failed. I also see other recent PR (#16627, #16624 and #16619) have similar build error message (Test kvmtest-t0 by Elastictest failed). So I think it's common build issue. Is there anything else I can do? Thanks.

@cytsai0409
Copy link
Contributor Author

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 16529 in repo sonic-net/sonic-buildimage

@cytsai0409
Copy link
Contributor Author

Currently Barefoot platform build failed on master branch. Close this PR for now until there is a fix for barefoot SAI library and then re-submit PR again.

@cytsai0409 cytsai0409 closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants