-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[Ufispace][PDDF] Add PDDF support on S9180-32X #16529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: cytsai0409 <[email protected]>
@FuzailBrcm @liushilongbuaa pls help review, thanks |
Hi @cytsai0409 , I see opt/bfn/install_x2_tofino opt/bfn/install_x1_tofino are same. They have the same files the same md5sum. But in bfnsdk package there are other folders and one entry soft link. I wonder if bfnplatform package covers all scenario? find bfnsdk/ | grep '/opt/bfn/install[a-z_0-9]*$' |
Hi, @liushilongbuaa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ufispace package LGTM.
@FuzailBrcm pls help review the pddf code changes. The only difference from #14909 in pddf is adding PDDF_PLATFORM_MODULE_SYM dependency rule in platform-modules-ufispace.mk as #16302 . Tks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I provided one comment. It can be taken care of later too. Marking it approve.
@@ -0,0 +1,9 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value for most of the fields is 'false'. You dont need to mention each one separately. Only this would have sufficed.
{
"skip_ledd": "true"
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually we list all daemons intentionally to make all things clear to us and easy to configure by switching true/false without remembering the "skip_damon_name" naming. Still appreciate you suggestion here.
@yxieca please help merge, thanks. |
1 similar comment
@yxieca please help merge, thanks. |
please retest, make sure the build is passing |
Ok, retest is ongoing. Tks. |
/azp run Azure.sonic-buildimage |
Commenter does not have sufficient privileges for PR 16529 in repo sonic-net/sonic-buildimage |
Currently Barefoot platform build failed on master branch. Close this PR for now until there is a fix for barefoot SAI library and then re-submit PR again. |
Why I did it
Add PDDF support on Ufispace S9180-32X with Barefoot ASIC.
Based on #14909, this PR fixed the race issue between bfnsdk_20221130_sai_1.11.0_deb11.deb and bfnplatform-ufispace_1.0.0_amd64.deb by creating new folder under /opt/bfn/install_x1_tofino and /opt/bfn/install_x2_tofino and putting our files there. This way the files in bfnsdk_20221130_sai_1.11.0_deb11.deb are not affected. For detail logs please see here #14909 (comment).
We also stress building the sonic images with multiple build process (SONIC_CONFIG_BUILD_JOBS=8) for weeks and did not see similar issue.
Note that there are only two files changed from #14909:
Other files remained the same as #14909.
How I did it
Add PDDF configuration files, scripts and python files
How to verify it
Run pddf commands and show commands.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)