To improve the error handling of vtysh read config file #15568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
reviewed
Jun 23, 2023
| @@ -0,0 +1,42 @@ | |||
| From 33a231ac26a46bfb728975d1695b7a71a7bc95ab Mon Sep 17 00:00:00 2001 | |||
| From: stormliang <[email protected]> | |||
There was a problem hiding this comment.
No, I this is not upstream patch, I create this one.
lguohan
reviewed
Jun 23, 2023
| } | ||
| + if (feof(fp)) { | ||
| + // Handle end-of-file (EOF) error | ||
| + vty_out(vty, "fgets error: End of file reached.\n"); |
There was a problem hiding this comment.
where do we see such message, in syslog?
There was a problem hiding this comment.
This PR is not ready for review yet, make it as draft.
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
When read from config file, if any i/o error, vtysh_b will return but doesn't drop any error msg, that would lead to silent failure. In this PR to improve the error handling when read from config file.
Work item tracking
How I did it
To deal with error of fgets
How to verify it
PR test
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)