Add authentication validation to the JSON schema #2646
Conversation
…ot sure if this is intended but it makes sense to me.
…sed. The error message is a bit janky, though
sander1095
requested review from
Aniruddh25,
aaronburtle,
RubenCerna2079,
ravishetye,
rohkhann,
neeraj-sharma2592,
sourabh1007 and
sezal98
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
@Aniruddh25 I've processed your comments. I took a look at the failures of the CI pipeline of the last commits. They seem to be unrelated to my changes: Let's hope that a re-run will make them go green! |
|
@RubenCerna2079 Could you perform a re-run on this PR :) |
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
I see I broke some config tests. I'll hopefully have time to look into this next week! |
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
Hi! I sadly haven't been able to work on this issue this week. I'll be moving house during the next few weeks. I probably won't have time to look until this until the end of May/beginning of June. If the team wants this merged, I'll sadly have to ask them to fix these tests. Otherwise I will fix them when I have time. |
|
@sander1095 thank you for your update. This PR can wait when you get more time to work on it. We appreciate your contributions and look forward to when you have updates on this. |
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
sander1095
requested review from
souvikghosh04,
vadeveka,
Alekhya-Polavarapu and
rusamant
as code owners
NJsonSchema validates the combination of oneof and const incorrectly. JSonSchema.NET does a better job at this.
…serialization issues
|
Hi @Aniruddh25 and @RubenCerna2079 ! I've found some to look into this PR. I've updated it. The failed unit tests now run correctly on my machine! There's 1 impactful change you should be aware of: I decided to move away from I think it's worth a try to run the pipelines again and see the results! If the integration fail again, please post the stacktraces. I can't access them as I get a 403 error when trying to see more details in Azure Pipelines. |
Why make this change?
Closes #2643
The JSON schema does not contain a list of auth providers, nor does it validate the use of the
jwtproperty. This results in a suboptimal developer experience. By adding this list and validation, developers have an easier time learning about all the options and can be more productive.What is this change?
jwtproperty.StackOverflow helped me with the finer details of the validation.NJsonSchematoJsonSchemaNetbecauseNJsonSchemadoesn't validateanyof + constcorrectly.JsonSchemaNetdoes support thishttpstohttpin the schema file to be spec compliant. Draft-07's original URL is http-based.httpsurl, it will fail because of the unknown schema URL.How was this tested?
Sample Request(s)