Skip to content

Use the updated config in regenerate step #10765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

JoshLove-msft
Copy link
Member

@JoshLove-msft JoshLove-msft commented May 28, 2025

@Copilot Copilot AI review requested due to automatic review settings May 28, 2025 17:31
@JoshLove-msft JoshLove-msft requested a review from a team as a code owner May 28, 2025 17:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the sparse-checkout step in the regenerate stage and switches to a full repository checkout.

  • Removes the custom sparse-checkout template
  • Adds a checkout: self step with fetchDepth: 0 to pull all files
Comments suppressed due to low confidence (2)

eng/common/pipelines/templates/archetype-typespec-emitter.yml:310

  • [nitpick] Clarify the inline comment by specifying the exact file path, e.g., # including changes in archetype-typespec-emitter/package.json to make the reason more explicit.
-            checkout: self # don't use sparse checkout here as we need the emitter package json changes

eng/common/pipelines/templates/archetype-typespec-emitter.yml:311

  • Using fetchDepth: 0 fetches the entire history, which can slow down the pipeline. Consider fetchDepth: 1 if only the latest commit is needed.
-            fetchDepth: 0

@JoshLove-msft JoshLove-msft changed the title Don't use sparse checkout in regenerate stage Publish the updated config as artifacts and use that when regenerating May 28, 2025
@JoshLove-msft JoshLove-msft changed the title Publish the updated config as artifacts and use that when regenerating Use the updated config in regenerate step May 29, 2025
@JoshLove-msft JoshLove-msft reopened this May 29, 2025
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request May 29, 2025
@JoshLove-msft JoshLove-msft enabled auto-merge (squash) May 29, 2025 20:26
@JoshLove-msft JoshLove-msft merged commit 1ddf113 into Azure:main May 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-update PR does not generate using the version of azure emitter it is updating to
3 participants