Skip to content

Commit 88d244a

Browse files
azure-sdkscbedd
andauthored
Sync eng/common directory with azure-sdk-tools for PR 8158 (#29423)
* allow an override FILE to be honored by test-proxy-tool * update test-utils to honor proxy override version by default --------- Co-authored-by: Scott Beddall (from Dev Box) <[email protected]>
1 parent 7706373 commit 88d244a

File tree

4 files changed

+32
-47
lines changed

4 files changed

+32
-47
lines changed

common/tools/dev-tool/src/util/testProxyUtils.ts

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -287,8 +287,7 @@ export async function isProxyToolActive(): Promise<boolean> {
287287
}
288288

289289
log.info(
290-
`Proxy tool seems to be active at http://localhost:${
291-
process.env.TEST_PROXY_HTTP_PORT ?? 5000
290+
`Proxy tool seems to be active at http://localhost:${process.env.TEST_PROXY_HTTP_PORT ?? 5000
292291
}\n`,
293292
);
294293
return true;
@@ -299,15 +298,30 @@ export async function isProxyToolActive(): Promise<boolean> {
299298

300299
async function getTargetVersion() {
301300
// Grab the tag from the `/eng/common/testproxy/target_version.txt` file [..is used to control the default version]
301+
//
302+
// In times of longer lived version override, the file eng/target_proxy_version.txt can be used to override this version
303+
// in both CI and local development.
302304
// Example content:
303305
//
304306
// 1.0.0-dev.20220224.2
305307
// (Bot regularly updates the tag in the file above.)
306308
try {
307-
const contentInVersionFile = await fs.readFile(
308-
`${path.join(await resolveRoot(), "eng/common/testproxy/target_version.txt")}`,
309-
"utf-8",
310-
);
309+
let contentInVersionFile: string;
310+
const overrideFile = `${path.join(await resolveRoot(), "eng/target_proxy_version.txt")}`;
311+
const overrideExists = await fs.exists(overrideFile);
312+
313+
if (overrideExists) {
314+
contentInVersionFile = await fs.readFile(
315+
overrideFile,
316+
"utf-8",
317+
);
318+
}
319+
else {
320+
contentInVersionFile = await fs.readFile(
321+
`${path.join(await resolveRoot(), "eng/common/testproxy/target_version.txt")}`,
322+
"utf-8",
323+
);
324+
}
311325

312326
const tag = contentInVersionFile.trim();
313327

eng/common/testproxy/test-proxy-docker.yml

Lines changed: 0 additions & 40 deletions
This file was deleted.

eng/common/testproxy/test-proxy-tool.yml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,17 @@ steps:
2222
pwsh: true
2323

2424
- pwsh: |
25-
$version = $(Get-Content "${{ parameters.templateRoot }}/eng/common/testproxy/target_version.txt" -Raw).Trim()
25+
$standardVersion = "${{ parameters.templateRoot }}/eng/common/testproxy/target_version.txt"
26+
$overrideVersion = "${{ parameters.templateRoot }}/eng/target_proxy_version.txt"
27+
28+
$version = $(Get-Content $standardVersion -Raw).Trim()
29+
30+
if (Test-Path $overrideVersion) {
31+
$version = $(Get-Content $overrideVersion -Raw).Trim()
32+
}
33+
34+
Write-Host "Installing test-proxy version $version"
35+
2636
dotnet tool install azure.sdk.tools.testproxy `
2737
--tool-path $(Build.BinariesDirectory)/test-proxy `
2838
--add-source https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-net/nuget/v3/index.json `

eng/target_proxy_version.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
1.0.0-dev.20240410.1

0 commit comments

Comments
 (0)