[azeventgrid] Use the common azcore/messaging/CloudEvent model (#21028)

* Using the new CloudEvent from azcore.
* Used @jhendrixMSFT's trick to cleanly remove "external" models, which removed even more code.
* Activated the live test part of the pipeline.

Author: richardpark-msft

sdk/messaging/azeventgrid/assets.json

@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "go",
   "TagPrefix": "go/messaging/azeventgrid",
-  "Tag": "go/messaging/azeventgrid_601fd733f2"
+  "Tag": "go/messaging/azeventgrid_b8c3771d17"
 }

sdk/messaging/azeventgrid/autorest.md

@@ -25,15 +25,6 @@ directive:
   - from: client.go
     where: $
     transform: return $.replace(/PublishCloudEvents\(/g, "internalPublishCloudEvents(");
-  # make sure the casing of the properties is what compliant.
-  # - from: swagger-document
-  #   where: $.definitions.CloudEvent.properties.data
-  #   transform: > 
-  #     $["type"] = "array"
-  # - from: swagger-document
-  #   where: $.definitions.CloudEvent.properties.data
-  #   transform: > 
-  #     $["items"] = {"type": "byte"}
   - from: swagger-document
     where: $.definitions.CloudEvent.properties.specversion
     transform: $["x-ms-client-name"] = "SpecVersion"
@@ -43,6 +34,19 @@ directive:
   - from: swagger-document
     where: $.definitions.CloudEvent.properties.dataschema
     transform: $["x-ms-client-name"] = "DataSchema"
+  # mark models as external so they're just omitted
+  - from: swagger-document
+    where: $.definitions.CloudEvent
+    transform: $["x-ms-external"] = true
+  - from: swagger-document
+    where: $.definitions.["Azure.Core.Foundations.Error"]
+    transform: $["x-ms-external"] = true
+  - from: swagger-document
+    where: $.definitions.["Azure.Core.Foundations.ErrorResponse"]
+    transform: $["x-ms-external"] = true
+  - from: swagger-document
+    where: $.definitions.["Azure.Core.Foundations.InnerError"]
+    transform: $["x-ms-external"] = true
   # make the endpoint a parameter of the client constructor
   - from: swagger-document
     where: $["x-ms-parameterized-host"]
@@ -54,11 +58,11 @@ directive:
       - response_types.go
     where: $
     transform: return $.replace(/Client(\w+)((?:Options|Response))/g, "$1$2");
+  # replace references to the "generated" CloudEvent to the actual version in azcore/messaging
   - from:
       - client.go
       - models.go
-      - models_serde.go
       - response_types.go
     where: $
-    transform: return $.replace(/AzureCoreFoundations/g, "");
+    transform: return $.replace(/\*CloudEvent/g, "messaging.CloudEvent");
 ```

sdk/messaging/azeventgrid/build.go

@@ -4,6 +4,6 @@
 // +build go1.18
 
 //go:generate autorest ./autorest.md
-//go:generate gofmt -w .
+//go:generate goimports -w .
 
 package azeventgrid

sdk/messaging/azeventgrid/ci.yml

@@ -2,28 +2,29 @@
 trigger:
   branches:
     include:
-    - main
-    - feature/*
-    - hotfix/*
-    - release/*
+      - main
+      - feature/*
+      - hotfix/*
+      - release/*
   paths:
     include:
-    - sdk/messaging/azeventgrid
-    - eng/
+      - sdk/messaging/azeventgrid
+      - eng/
 
 pr:
   branches:
     include:
-    - main
-    - feature/*
-    - hotfix/*
-    - release/*
+      - main
+      - feature/*
+      - hotfix/*
+      - release/*
   paths:
     include:
-    - sdk/messaging/azeventgrid
-    
+      - sdk/messaging/azeventgrid
 
 stages:
-- template: /eng/pipelines/templates/jobs/archetype-sdk-client.yml
-  parameters:
-    ServiceDirectory: 'messaging/azeventgrid'
+  - template: /eng/pipelines/templates/jobs/archetype-sdk-client.yml
+    parameters:
+      ServiceDirectory: "messaging/azeventgrid"
+      RunLiveTests: true
+      Location: westus2

sdk/messaging/azeventgrid/client.go

@@ -13,10 +13,9 @@ import (
 	"net/http"
 
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore"
+	"github.com/Azure/azure-sdk-for-go/sdk/azcore/messaging"
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore/policy"
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore/runtime"
-	"github.com/Azure/azure-sdk-for-go/sdk/azcore/to"
-	"github.com/Azure/azure-sdk-for-go/sdk/internal/uuid"
 )
 
 // ClientOptions contains optional settings for [Client]
@@ -59,27 +58,11 @@ func NewClientWithSharedKeyCredential(endpoint string, key string, options *Clie
 //   - topicName - Topic Name.
 //   - events - Array of Cloud Events being published.
 //   - options - ClientPublishCloudEventsOptions contains the optional parameters for the Client.PublishCloudEvents method.
-func (client *Client) PublishCloudEvents(ctx context.Context, topicName string, events []*CloudEvent, options *PublishCloudEventsOptions) (PublishCloudEventsResponse, error) {
+func (client *Client) PublishCloudEvents(ctx context.Context, topicName string, events []messaging.CloudEvent, options *PublishCloudEventsOptions) (PublishCloudEventsResponse, error) {
 	ctx = runtime.WithHTTPHeader(ctx, http.Header{
 		"Content-type": []string{"application/cloudevents-batch+json; charset=utf-8"},
 	})
 
-	for _, evt := range events {
-		if evt.ID == nil {
-			id, err := uuid.New()
-
-			if err != nil {
-				return PublishCloudEventsResponse{}, err
-			}
-
-			evt.ID = to.Ptr(id.String())
-		}
-
-		if evt.SpecVersion == nil || *evt.SpecVersion == "" {
-			evt.SpecVersion = &defaultSpecVersion
-		}
-	}
-
 	return client.internalPublishCloudEvents(ctx, topicName, events, options)
 }
 
@@ -92,5 +75,3 @@ func (p *skpolicy) Do(req *policy.Request) (*http.Response, error) {
 	req.Raw().Header.Add("Authorization", "SharedAccessKey "+p.Key)
 	return req.Next()
 }
-
-var defaultSpecVersion = "1.0"