Skip to content

Commit 7975f9a

Browse files
comments address
1 parent 6247571 commit 7975f9a

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

sdk/storage/azblob/service/client_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -321,9 +321,9 @@ type userAgentTest struct{}
321321
func (u userAgentTest) Do(req *policy.Request) (*http.Response, error) {
322322
const userAgentHeader = "User-Agent"
323323

324-
currentUserAgentHeader := map[string][]string(req.Raw().Header)[userAgentHeader]
325-
if !strings.HasPrefix(currentUserAgentHeader[0], "azsdk-go-azblob/"+exported.ModuleVersion) {
326-
return nil, fmt.Errorf(currentUserAgentHeader[0] + " user agent doesn't match expected agent: azsdk-go-azdatalake/v1.2.0 (go1.19.3; Windows_NT)")
324+
currentUserAgentHeader := req.Raw().Header.Get(userAgentHeader)
325+
if !strings.HasPrefix(currentUserAgentHeader, "azsdk-go-azblob/"+exported.ModuleVersion) {
326+
return nil, fmt.Errorf(currentUserAgentHeader + " user agent doesn't match expected agent: azsdk-go-azdatalake/v1.2.0 (go1.19.3; Windows_NT)")
327327
}
328328

329329
return &http.Response{

sdk/storage/azdatalake/file/client_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,9 @@ type userAgentTest struct{}
9797
func (u userAgentTest) Do(req *policy.Request) (*http.Response, error) {
9898
const userAgentHeader = "User-Agent"
9999

100-
currentUserAgentHeader := map[string][]string(req.Raw().Header)[userAgentHeader]
101-
if !strings.HasPrefix(currentUserAgentHeader[0], "azsdk-go-azdatalake/"+exported.ModuleVersion) {
102-
return nil, fmt.Errorf(currentUserAgentHeader[0] + " user agent doesn't match expected agent: azsdk-go-azdatalake/vx.xx.xx")
100+
currentUserAgentHeader := req.Raw().Header.Get(userAgentHeader)
101+
if !strings.HasPrefix(currentUserAgentHeader, "azsdk-go-azdatalake/"+exported.ModuleVersion) {
102+
return nil, fmt.Errorf(currentUserAgentHeader + " user agent doesn't match expected agent: azsdk-go-azdatalake/vx.xx.xx")
103103
}
104104

105105
return &http.Response{

sdk/storage/azfile/service/client_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -190,9 +190,9 @@ type userAgentTest struct{}
190190
func (u userAgentTest) Do(req *policy.Request) (*http.Response, error) {
191191
const userAgentHeader = "User-Agent"
192192

193-
currentUserAgentHeader := map[string][]string(req.Raw().Header)[userAgentHeader]
194-
if !strings.HasPrefix(currentUserAgentHeader[0], "azsdk-go-azfile/"+exported.ModuleVersion) {
195-
return nil, fmt.Errorf(currentUserAgentHeader[0] + " user agent doesn't match expected agent: azsdk-go-azfile/vx.xx.x")
193+
currentUserAgentHeader := req.Raw().Header.Get(userAgentHeader)
194+
if !strings.HasPrefix(currentUserAgentHeader, "azsdk-go-azfile/"+exported.ModuleVersion) {
195+
return nil, fmt.Errorf(currentUserAgentHeader + " user agent doesn't match expected agent: azsdk-go-azfile/vx.xx.x")
196196
}
197197

198198
return &http.Response{
@@ -208,7 +208,7 @@ func newTelemetryTestPolicy() policy.Policy {
208208
return &userAgentTest{}
209209
}
210210

211-
func TestUserAgentAzFile(t *testing.T) {
211+
func TestUserAgentForAzFile(t *testing.T) {
212212
client, err := service.NewClientWithNoCredential("https://fake/blob/testpath", &service.ClientOptions{
213213
ClientOptions: policy.ClientOptions{
214214
PerCallPolicies: []policy.Policy{newTelemetryTestPolicy()},

0 commit comments

Comments
 (0)