Skip to content

Change the order of credentials in the DefaultAzureCredential #4669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
antkmsft opened this issue May 30, 2023 · 3 comments · Fixed by #4946 or #6573
Closed

Change the order of credentials in the DefaultAzureCredential #4669

antkmsft opened this issue May 30, 2023 · 3 comments · Fixed by #4946 or #6573
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Milestone

Comments

@antkmsft
Copy link
Member

@scottaddie: "Wow the order of credentials was determined in the C++ DefaultAzureCredential. We typically put the dev tool credentials at the very end of the chain. We see Managed Identity as more important."
@antkmsft: "The order is the one I presented to the C++ team initially, but you are right, we should try to change it. Initially, I think, ManagedIdentityCredential was at the end because unlike other languages, our ManagedIdentityCredential does not probe the IP address yet, and just tries to get the token. But still, that should not be the factor that prevents it from being in the middle of the chain. The good thing is that everywhere in documentation we say that although we are documenting the order of credentials, we may change their order in the future, and that would not be considered a breaking change. So let me to open an issue to change the order, and update the docs and the SVG."

@github-actions github-actions bot added Azure.Identity Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage. labels May 30, 2023
@RickWinter RickWinter added bug This issue requires a change to an existing behavior in the product in order to be resolved. and removed needs-team-triage Workflow: This issue needs the team to triage. labels Jun 8, 2023
@RickWinter RickWinter self-assigned this Jun 8, 2023
@ahsonkhan
Copy link
Contributor

Re-opening #5156 until we fix the responsiveness of ManagedIdentityCredential on failure.
#4952

@ahsonkhan ahsonkhan reopened this Nov 11, 2023
@RickWinter RickWinter removed their assignment May 8, 2024
@RickWinter RickWinter moved this from Untriaged to Not Started in Azure Identity SDK Improvements May 8, 2024
@ahsonkhan ahsonkhan added this to the Backlog milestone May 20, 2024
@RickWinter RickWinter assigned antkmsft and unassigned ahsonkhan Jan 24, 2025
@RickWinter RickWinter moved this from Not Started to Backlog in Azure Identity SDK Improvements Feb 26, 2025
@RickWinter RickWinter removed the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Mar 6, 2025
Copy link

Hi @antkmsft, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 30, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
3 participants