Skip to content

Commit eb9c35d

Browse files
authored
Revert "Add Win32FileTimeConverter (#3941)" (#3966)
This reverts commit 14e4f52.
1 parent 91c67f9 commit eb9c35d

File tree

2 files changed

+1
-87
lines changed

2 files changed

+1
-87
lines changed

sdk/core/azure-core/inc/azure/core/datetime.hpp

Lines changed: 1 addition & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ inline bool operator>=(std::chrono::system_clock::time_point const& tp, DateTime
269269

270270
namespace Core { namespace _internal {
271271
/**
272-
* @brief Provides conversion methods for POSIX time to an #Azure::DateTime.
272+
* @brief Provides convertion methods for POSIX time to an #Azure::DateTime.
273273
*
274274
*/
275275
class PosixTimeConverter final {
@@ -311,51 +311,6 @@ namespace Core { namespace _internal {
311311
*/
312312
~PosixTimeConverter() = delete;
313313
};
314-
315-
/**
316-
* @brief Provides conversion methods for Win32 FILETIME to an #Azure::DateTime.
317-
*
318-
*/
319-
class Win32FileTimeConverter final {
320-
public:
321-
/**
322-
* @brief Converts Win32 FILETIME to an #Azure::DateTime.
323-
*
324-
* @param win32Filetime The number of 100-nanoseconds since 1601-01-01.
325-
* @return Calculated #Azure::DateTime.
326-
*/
327-
static DateTime Win32FileTimeToDateTime(int64_t win32Filetime)
328-
{
329-
auto t = DateTime(1601) + Azure::_detail::Clock::duration(win32Filetime);
330-
return DateTime(t);
331-
}
332-
333-
/**
334-
* @brief Converts a DateTime to Win32 FILETIME.
335-
*
336-
* @param dateTime The `%DateTime` to convert.
337-
* @return The number of 100-nanoseconds since 1601-01-01.
338-
*/
339-
static int64_t DateTimeToWin32FileTime(DateTime const& dateTime)
340-
{
341-
return std::chrono::duration_cast<Azure::_detail::Clock::duration>(dateTime - DateTime(1601))
342-
.count();
343-
}
344-
345-
private:
346-
/**
347-
* @brief An instance of `%Win32FileTimeConverter` class cannot be created.
348-
*
349-
*/
350-
Win32FileTimeConverter() = delete;
351-
352-
/**
353-
* @brief An instance of `%Win32FileTimeConverter` class cannot be destructed, because no
354-
* instance can be created.
355-
*
356-
*/
357-
~Win32FileTimeConverter() = delete;
358-
};
359314
}} // namespace Core::_internal
360315

361316
} // namespace Azure

sdk/core/azure-core/test/ut/datetime_test.cpp

Lines changed: 0 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -895,44 +895,3 @@ TEST(DateTime, LeapYear)
895895
EXPECT_NO_THROW(static_cast<void>(DateTime(2021, 2, 28)));
896896
EXPECT_THROW(static_cast<void>(DateTime(2021, 2, 29)), std::invalid_argument);
897897
}
898-
899-
TEST(DateTime, Win32FileTimeConverter)
900-
{
901-
using namespace Azure::Core::_internal;
902-
903-
EXPECT_EQ(
904-
Win32FileTimeConverter::DateTimeToWin32FileTime(
905-
Win32FileTimeConverter::Win32FileTimeToDateTime(0)),
906-
0);
907-
EXPECT_EQ(
908-
Win32FileTimeConverter::DateTimeToWin32FileTime(
909-
Win32FileTimeConverter::Win32FileTimeToDateTime(1)),
910-
1);
911-
EXPECT_EQ(
912-
Win32FileTimeConverter::DateTimeToWin32FileTime(
913-
Win32FileTimeConverter::Win32FileTimeToDateTime(133080315699856412)),
914-
133080315699856412);
915-
EXPECT_EQ(
916-
Win32FileTimeConverter::DateTimeToWin32FileTime(
917-
Win32FileTimeConverter::Win32FileTimeToDateTime(2650467743995784569)),
918-
2650467743995784569);
919-
920-
EXPECT_EQ(
921-
Win32FileTimeConverter::Win32FileTimeToDateTime(0).ToString(
922-
Azure::DateTime::DateFormat::Rfc3339, Azure::DateTime::TimeFractionFormat::AllDigits),
923-
"1601-01-01T00:00:00.0000000Z");
924-
EXPECT_EQ(
925-
Win32FileTimeConverter::Win32FileTimeToDateTime(1).ToString(
926-
Azure::DateTime::DateFormat::Rfc3339, Azure::DateTime::TimeFractionFormat::AllDigits),
927-
"1601-01-01T00:00:00.0000001Z");
928-
EXPECT_EQ(
929-
Win32FileTimeConverter::Win32FileTimeToDateTime(133080315699856412)
930-
.ToString(
931-
Azure::DateTime::DateFormat::Rfc3339, Azure::DateTime::TimeFractionFormat::AllDigits),
932-
"2022-09-19T03:26:09.9856412Z");
933-
EXPECT_EQ(
934-
Win32FileTimeConverter::Win32FileTimeToDateTime(2650467743995784569)
935-
.ToString(
936-
Azure::DateTime::DateFormat::Rfc3339, Azure::DateTime::TimeFractionFormat::AllDigits),
937-
"9999-12-31T23:59:59.5784569Z");
938-
}

0 commit comments

Comments
 (0)