Skip to content

Commit f3b22ea

Browse files
maxkatz6grokys
authored andcommitted
Merge pull request #6495 from workgroupengineering/fixes/Datagrid_Warnings
Fixes datagrid warnings
1 parent e5633d8 commit f3b22ea

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

src/Avalonia.Controls.DataGrid/Collections/DataGridGroupDescription.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,9 @@ object GetKey(object o)
8383
if (key == null)
8484
key = item;
8585

86-
if (_valueConverter != null)
87-
key = _valueConverter.Convert(key, typeof(object), level, culture);
86+
var valueConverter = ValueConverter;
87+
if (valueConverter != null)
88+
key = valueConverter.Convert(key, typeof(object), level, culture);
8889

8990
return key;
9091
}
@@ -99,6 +100,8 @@ public override bool KeysMatch(object groupKey, object itemKey)
99100
}
100101
public override string PropertyName => _propertyPath;
101102

103+
public IValueConverter ValueConverter { get => _valueConverter; set => _valueConverter = value; }
104+
102105
private Type GetPropertyType(object o)
103106
{
104107
return o.GetType().GetNestedPropertyType(_propertyPath);

src/Avalonia.Controls.DataGrid/Utils/CellEditBinding.cs

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
using Avalonia.Data;
22
using Avalonia.Reactive;
33
using System;
4-
using System.ComponentModel.DataAnnotations;
54
using System.Collections.Generic;
65
using System.Reactive.Subjects;
7-
using System.Text;
86

97
namespace Avalonia.Controls.Utils
108
{
@@ -67,11 +65,14 @@ public SubjectWrapper(ISubject<object> bindingSourceSubject, CellEditBinding edi
6765

6866
private void SetSourceValue(object value)
6967
{
70-
_settingSourceValue = true;
68+
if (!_settingSourceValue)
69+
{
70+
_settingSourceValue = true;
7171

72-
_sourceSubject.OnNext(value);
72+
_sourceSubject.OnNext(value);
7373

74-
_settingSourceValue = false;
74+
_settingSourceValue = false;
75+
}
7576
}
7677
private void SetControlValue(object value)
7778
{
@@ -157,4 +158,4 @@ public void CommitEdit()
157158
}
158159
}
159160
}
160-
}
161+
}

0 commit comments

Comments
 (0)