Fix crash in TreeView when removing a node. (#16041)

doubleday · web-flow · commit f2bee9acc0f0 · 2024-07-04T07:26:39.000Z
SelectedItems are already updated via TreeView.OnItemsViewCollectionChanged
diff --git a/samples/ControlCatalog/ViewModels/TreeViewPageViewModel.cs b/samples/ControlCatalog/ViewModels/TreeViewPageViewModel.cs
@@ -49,9 +49,8 @@ private void RemoveItem()
         {
             while (SelectedItems.Count > 0)
             {
-                Node lastItem = (Node)SelectedItems[0];
+                var lastItem = SelectedItems[0];
                 RecursiveRemove(Items, lastItem);
-                SelectedItems.RemoveAt(0);
             }
 
             bool RecursiveRemove(ObservableCollection<Node> items, Node selectedItem)

Original file line number	Diff line number	Diff line change
`@@ -49,9 +49,8 @@ private void RemoveItem()`
`49`	`49`	`{`
`50`	`50`	`while (SelectedItems.Count > 0)`
`51`	`51`	`{`
`52`		`- Node lastItem = (Node)SelectedItems[0];`
	`52`	`+ var lastItem = SelectedItems[0];`
`53`	`53`	`RecursiveRemove(Items, lastItem);`
`54`		`- SelectedItems.RemoveAt(0);`
`55`	`54`	`}`
`56`	`55`
`57`	`56`	`bool RecursiveRemove(ObservableCollection<Node> items, Node selectedItem)`