Skip to content

[Enhancement] showDialog in avalonia ui is async,could add a method named showDialogAsync with async tag in dialogService #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yaobiao131 opened this issue Nov 28, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request Prism-v9.0.x-pre Prism v9.0.x Pre-Release wontfix This will not be worked on

Comments

@yaobiao131
Copy link

Description

ShowDialog in avalonia ui is asynchronous. Should a method named showDialogAsync with an asynchronous tag be added to the dialogService to be compatible with wpf's showdialog?

Context

Add any other context, examples, or screenshots about the feature request here.

@yaobiao131 yaobiao131 added the enhancement New feature or request label Nov 28, 2023
@Coolkeke
Copy link

It is not recommended to do this as it can cause confusion for developers

@DamianSuess
Copy link
Collaborator

DamianSuess commented Apr 12, 2024

(Updated typos)
@yaobiao131, in v9.0.x IDialogService will implement an async call. This feature will not be backported. However, you are welcome to derive your own IDialogServiceExtension, check out the PR link below.

public static Task<IDialogResult> ShowDialogAsync(this IDialogService dialogService, string name) { ... }

public static Task<IDialogResult> ShowDialogAsync(this IDialogService dialogService, string name, IDialogParameters parameters) { ... }

With the Prism 9.0.x upgrades the IDialogService interface has moved into the framework's Prism.Core for standardization across the platforms. Check out #129 Prism v9.0.271-pre upgrade

@DamianSuess DamianSuess added wontfix This will not be worked on Prism-v9.0.x-pre Prism v9.0.x Pre-Release labels Apr 12, 2024
@DamianSuess DamianSuess added this to the Prism 9.0.x milestone Apr 12, 2024
@DamianSuess DamianSuess self-assigned this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Prism-v9.0.x-pre Prism v9.0.x Pre-Release wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants