Skip to content

Attribute definition discrepency in automationPrice.tasks v.s. system events #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrisli30 opened this issue Oct 6, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@chrisli30
Copy link
Member

When calling extrinsics and querying system events, I find it’s cumbersome but to have two sets of names. For example, in events of automationPrice, who and taskId are used, but in data storage, it becomes taskId, ownerId.

TaskScheduled Event
{ who, taskId }

automationPrice.tasks
{
ownerId: 6757gffjjMc7E4sZJtkfvq8fmMzH2NPRrEL3f3tqpr2PzXYq
taskId: 1549-0-1
...
}

I think we should define a standard for those names.

  1. The who is not a good name, because both owner and scheduleAs are "who"s. We should just call the creator of the task, "owner".
  2. The "taskId" seems good so far.

A reminder that if we change the "who" to "owner" in events, we will need to update automationTime and data Insights service as well.

@chrisli30 chrisli30 added the enhancement New feature or request label Oct 6, 2023
@v9n v9n closed this as completed in 38044fe Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants