Dashboard v2: switcher: enable add site button

[ellatrix]

See #103344.

Proposed Changes

Why are these changes being made?

• The button currently doesn't work.

Testing Instructions

• Click the site switcher's add new site button.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-145892

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-145892&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-145892&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~4666 bytes added 📈 [gzipped])

name                    parsed_size           gzip_size
entry-dashboard-dotcom       +800 B  (+0.0%)     +190 B  (+0.0%)
entry-dashboard-a4a          +800 B  (+0.0%)     +190 B  (+0.0%)
entry-subscriptions          +683 B  (+0.0%)     +542 B  (+0.1%)
entry-stepper                +683 B  (+0.0%)     +542 B  (+0.1%)
entry-reauth-required        +683 B  (+0.0%)     +540 B  (+0.1%)
entry-main                   +683 B  (+0.0%)     +540 B  (+0.1%)
entry-login                  +683 B  (+0.0%)     +541 B  (+0.1%)
entry-domains-landing        +462 B  (+0.1%)     +633 B  (+0.3%)
entry-browsehappy            +397 B  (+0.2%)     +112 B  (+0.2%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[youknowriad]

Please no, this is going to prevent sharing the component with V1. Let's leave the component as is and instead have a separate one (or just use the modal inline)

[youknowriad]

See #103488

[ellatrix]

Why do we want to share it if it's going to be redesigned?

[ellatrix]

Also why does the modal prevent using another component inside of it?

[youknowriad]

Why do we want to share it if it's going to be redesigned?

That way it's redesigned for both. Right now it's exactly the same code that is duplicated.

Also why does the modal prevent using another component inside of it?

That's fine, I'm just saying that the reusable component shouldn't change from "content" to "modal".

[ellatrix]

@youknowriad better?

[youknowriad]

Yes, this works for me.

Initially I thought we wanted to keep the regular "add new site" button as a dropdown though?

[youknowriad]

If we want all of them to be a Modal, It's ok to have another dedicated component (different from the existing one) to share the logic.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/switcher-add-site on your sandbox.