Hosting Dashboard: Previews in sites grid are rendered using mShots where possible #103617
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Proposal to use our mShots screenshot service when possible (https://github.com/automattic/mshots)
mShots uses Chromium in a webservice to screenshot the site and caches it. We use the
s0.wp.com
CDN to service the image quickly.A proof of concept. Other work to do:
sizes
andsrcset
image attributes to determine theWhy are these changes being made?
The sites grid is very heavy to load
My network tab looks like this when the grid is loaded with iframes
When I switching to mshots it looks like this
Testing Instructions
Pre-merge Checklist