Skip to content

Apply column layout to migration instructions #103500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 21, 2025

Conversation

andres-blanco
Copy link
Contributor

@andres-blanco andres-blanco commented May 16, 2025

Closes DOTOBRD-64

Proposed Changes

Apply the new container v2 column layout to the site migration instructions step.

This is still a WIP since

  • we might need some changes on the new Layout or design input.
  • I need to conditionally add support when no preview is available.
  • Fix the tests

Desktop with preview

before after
image image

Mobile with preview

before after
image image

Desktop without preview

before after
image image

Mobile without preview

before after
image image

Why are these changes being made?

To conform with the rest of the onboarding design

Testing Instructions

  • Open the calypso.live link in the comments
  • Navigate to /setup/site-migration
  • Enter a WP site (a jurassic ninja site will work)
  • Click on the top right link to go through the Do it yourself experience
  • Pay
  • Check the mobile/desktop view
  • Remove the from query param from the URL and reload to load the view without preview.
  • Check the mobile/desktop view without the preview

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@andres-blanco andres-blanco self-assigned this May 16, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@andres-blanco andres-blanco force-pushed the DOTOBRD-64-apply-new-layout branch from cfe3cd5 to 926a707 Compare May 20, 2025 13:32
@andres-blanco andres-blanco changed the title [WIP] Apply column layout to migration instructions Apply column layout to migration instructions May 20, 2025
@matticbot
Copy link
Contributor

matticbot commented May 20, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug DOTOBRD-64-apply-new-layout on your sandbox.

@@ -82,7 +82,11 @@ describe( 'SiteMigrationInstructions', () => {
it( 'should render preview column', async () => {
const { container } = render();

expect( container.querySelector( '.launchpad-container__main-content' ) ).toBeInTheDocument();
expect(
Copy link
Contributor

@gabrielcaires gabrielcaires May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use an aria label to describe the preview panel, something like:
<div aria-label= {translate("Preview image from my")}>

and
getByLabelText

@fditrapani fditrapani self-requested a review May 20, 2025 20:05
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 20, 2025
Copy link
Contributor

@fditrapani fditrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the preview and without. Looks good to me!

@andres-blanco andres-blanco force-pushed the DOTOBRD-64-apply-new-layout branch from 5f24a70 to 549b4c8 Compare May 21, 2025 12:57
@andres-blanco andres-blanco merged commit 5720c76 into trunk May 21, 2025
11 checks passed
@andres-blanco andres-blanco deleted the DOTOBRD-64-apply-new-layout branch May 21, 2025 13:09
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants