-
Notifications
You must be signed in to change notification settings - Fork 2k
Apply column layout to migration instructions #103500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
cfe3cd5
to
926a707
Compare
...ng/stepper/declarative-flow/internals/steps-repository/site-migration-instructions/index.tsx
Show resolved
Hide resolved
...ng/stepper/declarative-flow/internals/steps-repository/site-migration-instructions/index.tsx
Outdated
Show resolved
Hide resolved
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
@@ -82,7 +82,11 @@ describe( 'SiteMigrationInstructions', () => { | |||
it( 'should render preview column', async () => { | |||
const { container } = render(); | |||
|
|||
expect( container.querySelector( '.launchpad-container__main-content' ) ).toBeInTheDocument(); | |||
expect( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use an aria label to describe the preview panel, something like:
<div aria-label= {translate("Preview image from my")}>
and
getByLabelText
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with the preview and without. Looks good to me!
5f24a70
to
549b4c8
Compare
Closes DOTOBRD-64
Proposed Changes
Apply the new container v2 column layout to the site migration instructions step.
This is still a WIP since
Desktop with preview
Mobile with preview
Desktop without preview
Mobile without preview
Why are these changes being made?
To conform with the rest of the onboarding design
Testing Instructions
/setup/site-migration
from
query param from the URL and reload to load the view without preview.Pre-merge Checklist