Account: Clean-up profile settings #103464
Conversation
- Removed unnecessary field notes on display name and web address. - Moved public profile URL to the bottom of the page. - Improved copy for Gravatar explanation. Related to DOTCOM-12845
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~60 bytes removed 📉 [gzipped]) Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
matticbot
added
the
[Status] Needs Review
|
Nice, looks good, close ot landing. Could use a glance from @michaelpick. One thing stood out:
I've recently understood from the ExternalLink component that the ↗ should not be underlined. Not a blocker for this PR since this is an existing issue, but it's especially the gap between the link and the ↗ arrow that stands out to me. |
This is bugging me too. I'll fix it in a separate PR. |
| @@ -24,6 +24,10 @@ | |||
| } | |||
| } | |||
|
|
|||
| .profile__settings .profile__public-url { | |||
There was a problem hiding this comment.
It'd be nice if we could avoid local CSS like this.
There was a problem hiding this comment.
+1. Some utility classes would be helpful for cases like this. AFAIK we don’t currently have any though.
|
I've reviewed the Calypso Live link, and it works for me, @matt-west. Thanks for working on it 💪 |
|
cc: @Automattic/loop for the changes in the |
| <p className="profile__public-url"> | ||
| { this.props.translate( 'View your public profile at {{a}}{{url/}}{{/a}}.', { | ||
| components: { | ||
| a: <ExternalLink href={ relativeProfileUrl } />, |
There was a problem hiding this comment.
Is this expected to change this to an external link? Now it requires a full page reload even though technically the page is still within Calypso.
There was a problem hiding this comment.
Yep. The profile page should open in a new tab so that state of the profile settings page is maintained.
We have a prompt if the user leaves the page with unsaved settings, but we’re then forcing them to choose whether to save changes before they can see the profile. I should think most people click this link out of curiosity and don’t deliberately come here to access their profile.
github-actions
bot
removed
the
[Status] Needs Review
|
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17480870 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @matt-west for including a screenshot in the description! This is really helpful for our translators. |
|
Translation for this Pull Request has now been finished. |
Related to DOTCOM-12845
Proposed Changes
We have some additional ideas for improving the overall layout of this page, but those will be tackled as part of the hosting dashboard redesign.
I also fixed some translation issues for English (UK) where we have inconsistent capitalization. These are not included as part of this PR.
Why are these changes being made?
Related to Code Blue reports in DOTCOM-12845.
Testing Instructions
yarn start/meand verify that all the changes are visible.