Skip to content

Notifications: change Email subscriptions tab and section title #103356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

CGastrell
Copy link
Contributor

@CGastrell CGastrell commented May 12, 2025

Part of DOTCOM-13033

Proposed Changes

This PR is a copy change on the "Email subscriptions" -> "Subscription settings" tab and its content title.

Why are these changes being made?

Design review DOTCOM-12890

Testing Instructions

Navigate to /me and into "Notification Settings". See the last tab is now called "Subscription settings". Click on it, see the section title matches "Subscription settings".

Before:
image

After:
image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@CGastrell CGastrell self-assigned this May 12, 2025
@CGastrell CGastrell added [Feature] Notifications Site notifications. [Type] Task [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels May 12, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@a8ci18n
Copy link

a8ci18n commented May 12, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17462172

Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @CGastrell for including a screenshot in the description! This is really helpful for our translators.

@CGastrell CGastrell changed the title change tab and section title Notifications: change Email subscriptions tab and section title May 12, 2025
@a8ci18n
Copy link

a8ci18n commented May 18, 2025

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Notifications Site notifications. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging [Type] Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants