Broaden ESLint Node.js configuration to apply to nested directories (#103550)

Author: aduth

.eslintrc.js

@@ -60,7 +60,7 @@ module.exports = {
 			},
 		},
 		{
-			files: [ 'bin/**/*', 'test/**/*' ],
+			files: [ '**/bin/**/*', '**/test/**/*', 'webpack.config.js' ],
 			...nodeConfig,
 		},
 		{

apps/happy-blocks/bin/build-translations-manifest.js

@@ -1,6 +1,5 @@
 #!/usr/bin/env node
 
-/* eslint-disable import/no-nodejs-modules */
 const fs = require( 'fs' );
 const path = require( 'path' );
 const glob = require( 'glob' );

apps/happy-blocks/webpack.config.js

@@ -1,7 +1,6 @@
 /**
  * WARNING: No ES6 modules here. Not transpiled!
  */
-// eslint-disable-next-line import/no-nodejs-modules
 const { existsSync } = require( 'fs' );
 const path = require( 'path' );
 const getBaseWebpackConfig = require( '@automattic/calypso-build/webpack.config.js' );

desktop/test/e2e/specs/login.js

@@ -1,4 +1,3 @@
-/* eslint-disable no-console, import/no-nodejs-modules */
 const { createWriteStream } = require( 'fs' );
 const { mkdir } = require( 'fs/promises' );
 const path = require( 'path' );

packages/calypso-build/bin/calypso-build.js

@@ -3,7 +3,6 @@
 /**
  *WARNING: No ES6 modules here. Not transpiled! ****
  */
-/* eslint-disable import/no-nodejs-modules */
 
 const fs = require( 'fs' );
 const path = require( 'path' );

packages/calypso-build/webpack.config.js

@@ -1,8 +1,6 @@
 /**
  * WARNING: No ES6 modules here. Not transpiled! *
  */
-/* eslint-disable import/no-nodejs-modules */
-
 const fs = require( 'fs' );
 const path = require( 'path' );
 const process = require( 'process' );

packages/calypso-color-schemes/bin/build-css.js

@@ -1,4 +1,3 @@
-/* eslint-disable import/no-nodejs-modules */
 const { existsSync, mkdirSync, writeFileSync } = require( 'fs' );
 const { dirname, join } = require( 'path' );
 const postcss = require( 'postcss' );

packages/calypso-color-schemes/bin/prepare-sass-assets.js

@@ -1,4 +1,3 @@
-/* eslint-disable import/no-nodejs-modules */
 const { copyFileSync, existsSync, mkdirSync } = require( 'fs' );
 const { basename, dirname, join } = require( 'path' );
 

packages/components/.eslintrc.js

@@ -3,12 +3,6 @@ module.exports = {
 		browser: true,
 	},
 	overrides: [
-		{
-			files: [ '**/test/**/*' ],
-			rules: {
-				'import/no-nodejs-modules': 'off',
-			},
-		},
 		{
 			// These are consumed only by Calypso's webpack build, it is ok to import other Calypso components
 			files: [ '**/docs/example.jsx', '*.md.js', '*.md.jsx' ],

packages/generate-password/src/test/index.ts

@@ -1,7 +1,6 @@
 /**
  * @jest-environment jsdom
  */
-// eslint-disable-next-line import/no-nodejs-modules
 import { webcrypto } from 'node:crypto';
 import { generatePassword, DIGITS, SPECIAL_CHARS, EXTRA_SPECIAL_CHARS } from '../';
 

packages/plans-grid-next/.eslintrc.js

@@ -3,12 +3,6 @@ module.exports = {
 		browser: true,
 	},
 	overrides: [
-		{
-			files: [ '**/test/**/*' ],
-			rules: {
-				'import/no-nodejs-modules': 'off',
-			},
-		},
 		{
 			// These are consumed only by Calypso's webpack build, it is ok to import other Calypso components
 			files: [ '**/docs/example.jsx', '*.md.js', '*.md.jsx' ],

packages/verbum-block-editor/bin/build-languages.js

@@ -1,5 +1,3 @@
-/* eslint-disable no-console */
-/* eslint-disable import/no-nodejs-modules */
 /**
  * Build a single language file for each language to `dist/languages` folder.
  */

packages/wpcom.js/.eslintrc.js

@@ -26,9 +26,6 @@ module.exports = {
 				// These files use a weird mixture of CJS and ESM. Disabling the rules for now until they can
 				// get refactored.
 				'import/default': 'off',
-
-				// Test can use Node modules
-				'import/no-nodejs-modules': 'off',
 			},
 		},
 	],