Skip to content

Commit 8a5afd9

Browse files
committed
Fix progress bar jump between loading states
1 parent 560e078 commit 8a5afd9

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

.stylelintrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@
5151
"fr",
5252
"ms",
5353
"px",
54+
"lh",
5455
"rem",
5556
"s",
5657
"vh",

packages/onboarding/src/step-container-v2/components/Heading/style.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@
1616
line-height: 1.25;
1717
text-wrap: balance;
1818

19+
// This ensures that the heading is always at least as tall as the line height.
20+
// Useful in case of empty loading titles so we don't see the progress bar jump around.
21+
min-height: 1lh;
22+
1923
&:not( .small ) {
2024
@include break-large {
2125
font-size: 2.75rem;

0 commit comments

Comments
 (0)