Made the setting work.

Author: peterfabian

includes/class-wc-subscriptions-email-notifications.php

@@ -10,6 +10,9 @@
  * @category   Class
  */
 class WC_Subscriptions_Email_Notifications {
+
+	public static string $offset_setting_string = '_customer_notifications_offset';
+
 	public static function init() {
 
 		add_action( 'woocommerce_email_classes', __CLASS__ . '::add_emails', 10, 1 );
@@ -205,13 +208,13 @@ public static function add_settings( $settings ) {
 				'type' => 'title',
 				'id'   => WC_Subscriptions_Admin::$option_prefix . '_customer_notifications',
 				/* translators: Link to WC Settings > Email. */
-				'desc' => sprintf( __( 'To enable and disable notification, visit the <a href="%s">Email settings</a>.', 'woocommerce-subscriptions' ), admin_url( 'admin.php?page=wc-settings&tab=email' ) ),
+				'desc' => sprintf( __( 'To enable and disable individual notifications, visit the <a href="%s">Email settings</a>.', 'woocommerce-subscriptions' ), admin_url( 'admin.php?page=wc-settings&tab=email' ) ),
 			),
 			array(
-				'name'        => __( 'Hour Offset', 'woocommerce-subscriptions' ),
-				'desc'        => __( 'How many hours in before the event should the notification be sent.', 'woocommerce-subscriptions' ),
+				'name'        => __( 'Time Offset', 'woocommerce-subscriptions' ),
+				'desc'        => __( 'How long before the event should the notification be sent.', 'woocommerce-subscriptions' ),
 				'tip'         => '',
-				'id'          => WC_Subscriptions_Admin::$option_prefix . '_customer_notifications_offset',
+				'id'          => WC_Subscriptions_Admin::$option_prefix . self::$offset_setting_string,
 				'desc_tip'    => true,
 				'type'        => 'relative_date_selector',
 				'placeholder' => __( 'N/A', 'woocommerce-subscriptions' ),

includes/class-wcs-action-scheduler-customer-notifications.php

@@ -45,8 +45,42 @@ public function set_hours_offset( $hours_offset ) {
 	public function __construct() {
 		parent::__construct();
 
-		//TODO: make number of hours configurable.
-		$this->hours_offset = 3 * DAY_IN_SECONDS / HOUR_IN_SECONDS; // aka 3 days in hours.
+		$setting_option     = get_option(
+			WC_Subscriptions_Admin::$option_prefix . WC_Subscriptions_Email_Notifications::$offset_setting_string,
+			array(
+				'number' => 3,
+				'unit'   => 'days',
+			)
+		);
+		$this->hours_offset = self::convert_offset_to_hours( $setting_option );
+	}
+
+	/**
+	 * Calculate time offset in hours from the settings array.
+	 *
+	 * @param array $offset Format: array( 'number' => 3, 'unit' => 'days' )
+	 *
+	 * @return float|int
+	 */
+	protected static function convert_offset_to_hours( $offset ) {
+		$default_offset = 3 * DAY_IN_SECONDS / HOUR_IN_SECONDS;
+
+		if ( ! isset( $offset['unit'] ) || ! isset( $offset['number'] ) ) {
+			return $default_offset;
+		}
+
+		switch ( $offset['unit'] ) {
+			case 'days':
+				return ( $offset['number'] * DAY_IN_SECONDS / HOUR_IN_SECONDS );
+			case 'weeks':
+				return ( $offset['number'] * WEEK_IN_SECONDS / HOUR_IN_SECONDS );
+			case 'months':
+				return ( $offset['number'] * MONTH_IN_SECONDS / HOUR_IN_SECONDS );
+			case 'years':
+				return ( $offset['number'] * YEAR_IN_SECONDS / HOUR_IN_SECONDS );
+			default:
+				return $default_offset;
+		}
 	}
 
 	public function set_date_types_to_schedule() {