Skip to content

Handle error and empty subscription states #4024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2025
Merged

Conversation

MiSikora
Copy link
Contributor

@MiSikora MiSikora commented May 21, 2025

Description

Improves UX for invalid states during the subscription purchase flow.

Designs: 2MA6Bz3Vi36BOhuR9pitCU-fi-325_12576

Closes: #3760

Testing Instructions

  1. Apply this patch.
curl -L https://github.com/user-attachments/files/20367006/plans-state.patch | git apply
  1. Sign up.
  2. During the onboarding flow, when you see the empty state, tap "Skip for now".
  3. You should be able to skip purchasing a subscription.
  4. Finish the onboarding process.
  5. Go to the Profile tab.
  6. Scroll to the bottom and tap the Pocket Cast Plus banner.
  7. You should see the subscription plans empty state.
  8. There should be no "Skip for now" button.
  9. Tap "Try again".
  10. The plans should load.
  11. Try to purchase a subscription.
  12. You should see an error snackbar.

Screenshots or Screencast

Empty state Error state
e Screenshot_20250521-134123

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@MiSikora MiSikora added this to the 7.90 milestone May 21, 2025
@MiSikora MiSikora requested a review from a team as a code owner May 21, 2025 11:47
@MiSikora MiSikora added the [Type] Enhancement Improve an existing feature. label May 21, 2025
@MiSikora MiSikora requested review from geekygecko and removed request for a team May 21, 2025 11:47
@MiSikora MiSikora added the [Area] Subscriptions Plus or Patron issue label May 21, 2025
@MiSikora MiSikora force-pushed the task/upsell/empty-state branch from 7f8aa59 to 43ab8a8 Compare May 21, 2025 11:48
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 21, 2025

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commitf17df47
Direct Downloadpocketcasts-app-prototype-build-pr4024-f17df47.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commitf17df47
Direct Downloadpocketcasts-automotive-prototype-build-pr4024-f17df47.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commitf17df47
Direct Downloadpocketcasts-wear-prototype-build-pr4024-f17df47.apk

@MiSikora MiSikora added [Area] Onboarding and removed [Area] Subscriptions Plus or Patron issue labels May 22, 2025
Copy link
Member

@geekygecko geekygecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great!

@geekygecko geekygecko merged commit bd14ef2 into main May 22, 2025
23 of 25 checks passed
@geekygecko geekygecko deleted the task/upsell/empty-state branch May 22, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Area] Onboarding [Type] Enhancement Improve an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error state for onboarding subscription plans
3 participants