Merge pull request #5166 from Automattic/2190

fix(model): return saved docs when create() fails

Author: vkarpov15

lib/model.js

@@ -1878,6 +1878,7 @@ Model.create = function create(doc, callback) {
     }
 
     var toExecute = [];
+    var firstError;
     args.forEach(function(doc) {
       toExecute.push(function(callback) {
         var Model = _this.discriminators && doc[discriminatorKey] ?
@@ -1886,9 +1887,12 @@ Model.create = function create(doc, callback) {
         var toSave = doc instanceof Model ? doc : new Model(doc);
         var callbackWrapper = function(error, doc) {
           if (error) {
-            return callback(error);
+            if (!firstError) {
+              firstError = error;
+            }
+            return callback(null, { error: error });
           }
-          callback(null, doc);
+          callback(null, { doc: doc });
         };
 
         // Hack to avoid getting a promise because of
@@ -1901,12 +1905,20 @@ Model.create = function create(doc, callback) {
       });
     });
 
-    parallel(toExecute, function(error, savedDocs) {
-      if (error) {
+    parallel(toExecute, function(error, res) {
+      var savedDocs = [];
+      var len = res.length;
+      for (var i = 0; i < len; ++i) {
+        if (res[i].doc) {
+          savedDocs.push(res[i].doc);
+        }
+      }
+
+      if (firstError) {
         if (cb) {
-          cb(error);
+          cb(firstError, savedDocs);
         } else {
-          reject(error);
+          reject(firstError);
         }
         return;
       }
@@ -1917,8 +1929,7 @@ Model.create = function create(doc, callback) {
       } else {
         resolve.apply(promise, savedDocs);
         if (cb) {
-          savedDocs.unshift(null);
-          cb.apply(_this, savedDocs);
+          cb.apply(_this, [null].concat(savedDocs));
         }
       }
     });