Skip to content

Commit acc6ac5

Browse files
authored
Merge pull request #5116 from Automattic/5064
Pass params to pre hooks
2 parents 71d85b1 + e79681d commit acc6ac5

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

lib/model.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3635,7 +3635,10 @@ Model.compile = function compile(name, schema, collectionName, connection, base)
36353635
model.Query.base = Query.base;
36363636
applyQueryMethods(model, schema.query);
36373637

3638-
var kareemOptions = { useErrorHandlers: true };
3638+
var kareemOptions = {
3639+
useErrorHandlers: true,
3640+
numCallbackParams: 1
3641+
};
36393642
model.$__insertMany = model.hooks.createWrapper('insertMany',
36403643
model.insertMany, model, kareemOptions);
36413644
model.insertMany = function(arr, options, callback) {

test/model.test.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5345,7 +5345,15 @@ describe('Model', function() {
53455345
});
53465346
var calledPre = 0;
53475347
var calledPost = 0;
5348-
schema.pre('insertMany', function(next) {
5348+
schema.pre('insertMany', function(next, docs) {
5349+
assert.equal(docs.length, 2);
5350+
assert.equal(docs[0].name, 'Star Wars');
5351+
++calledPre;
5352+
next();
5353+
});
5354+
schema.pre('insertMany', function(next, docs) {
5355+
assert.equal(docs.length, 2);
5356+
assert.equal(docs[0].name, 'Star Wars');
53495357
++calledPre;
53505358
next();
53515359
});
@@ -5358,7 +5366,7 @@ describe('Model', function() {
53585366
Movie.insertMany(arr, function(error, docs) {
53595367
assert.ifError(error);
53605368
assert.equal(docs.length, 2);
5361-
assert.equal(calledPre, 1);
5369+
assert.equal(calledPre, 2);
53625370
assert.equal(calledPost, 1);
53635371
done();
53645372
});

0 commit comments

Comments
 (0)