fix(documentarray): fix error when modifying array after slice()

vkarpov15 · vkarpov15 · commit a3b4ea17ddf2 · 2019-11-17T09:25:49.000-05:00
Fix #8317
diff --git a/lib/types/documentarray.js b/lib/types/documentarray.js
@@ -172,6 +172,14 @@ class CoreDocumentArray extends CoreMongooseArray {
     }));
   }
 
+  slice() {
+    const arr = super.slice.apply(this, arguments);
+    arr[arrayParentSymbol] = this[arrayParentSymbol];
+    arr[arrayPathSymbol] = this[arrayPathSymbol];
+
+    return arr;
+  }
+
   /**
    * Wraps [`Array#push`](https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Array/push) with proper change tracking.
    *

Original file line number	Diff line number	Diff line change
`@@ -172,6 +172,14 @@ class CoreDocumentArray extends CoreMongooseArray {`
`172`	`172`	`}));`
`173`	`173`	`}`
`174`	`174`
	`175`	`+ slice() {`
	`176`	`+ const arr = super.slice.apply(this, arguments);`
	`177`	`+ arr[arrayParentSymbol] = this[arrayParentSymbol];`
	`178`	`+ arr[arrayPathSymbol] = this[arrayPathSymbol];`
	`179`	`+`
	`180`	`+ return arr;`
	`181`	`+ }`
	`182`	`+`
`175`	`183`	`/**`
`176`	`184`	* Wraps [`Array#push`](https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Array/push) with proper change tracking.
`177`	`185`	`*`