Skip to content

Commit 36c3c22

Browse files
committed
iox-#33 Rebase with current master
Signed-off-by: Christian Eltzschig <[email protected]>
1 parent 808ed79 commit 36c3c22

File tree

3 files changed

+1
-8
lines changed

3 files changed

+1
-8
lines changed

iceoryx_hoofs/include/iceoryx_hoofs/internal/posix_wrapper/shared_memory_object/shared_memory.hpp

-3
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,6 @@ class SharedMemory : public DesignPattern::Creation<SharedMemory, SharedMemoryEr
9090

9191
/// @brief returns the file handle of the shared memory
9292
int32_t getHandle() const noexcept;
93-
bool hasOwnership() const noexcept;
94-
95-
static bool unlinkIfExist(const Name_t& name) noexcept;
9693

9794
/// @brief this class has the ownership of the shared memory when the shared
9895
/// memory was created by this class. This is the case when this class

iceoryx_hoofs/source/posix_wrapper/named_pipe.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ cxx::expected<bool, IpcChannelError> NamedPipe::isOutdated() noexcept
205205
cxx::expected<bool, IpcChannelError> NamedPipe::unlinkIfExists(const IpcChannelName_t& name) noexcept
206206
{
207207
constexpr int ERROR_CODE = -1;
208-
auto unlinkCall = posixCall(iox_shm_unlink)(convertName(name).c_str())
208+
auto unlinkCall = posixCall(iox_shm_unlink)(convertName(NAMED_PIPE_PREFIX, name).c_str())
209209
.failureReturnValue(ERROR_CODE)
210210
.ignoreErrnos(ENOENT)
211211
.evaluate();

iceoryx_hoofs/test/moduletests/test_shared_memory_object.cpp

-4
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,7 @@ TEST_F(SharedMemoryObject_Test, AllocateMemoryInSharedMemoryAndReadIt)
7676
auto sut = iox::posix::SharedMemoryObject::create("/shmAllocate",
7777
16,
7878
iox::posix::AccessMode::READ_WRITE,
79-
<<<<<<< HEAD
8079
iox::posix::OpenMode::PURGE_AND_CREATE,
81-
=======
82-
iox::posix::Policy::PURGE_AND_CREATE,
83-
>>>>>>> 4f0fc4f36 (iox-#33 removed implicit shm removal from posix wrapper and packed it into explicit policy)
8480
iox::posix::SharedMemoryObject::NO_ADDRESS_HINT);
8581
int* test = static_cast<int*>(sut->allocate(sizeof(int), 1));
8682
ASSERT_THAT(test, Ne(nullptr));

0 commit comments

Comments
 (0)