Added two text editors so users can choose which one to use #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OR env variable. Nano will be used by default
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 5831bb3 in 52 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. docker/Dockerfile:9
- Draft comment:
Added text editors vim and nano. Ensure that including these packages in the builder stage and copying /usr/bin to the final stage is intentional, as it may add unneeded packages to the final image. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%
None
2. docker/Dockerfile:9
- Draft comment:
Addition of 'vim' and 'nano' addresses the missing editor issue. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
3. docker/Dockerfile:24
- Draft comment:
Copying the entire /usr/bin from the builder stage may override system binaries in the final image. It might be more robust to install only needed runtime packages directly in the final stage. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. docker/Dockerfile:31
- Draft comment:
Consider explicitly setting the default EDITOR (e.g. ENV EDITOR=nano) if not handled in entrypoint.sh, to match the PR description. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_20m60WyaBdetH8vD
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Docker container used in the the instructions https://github.com/AntonOsika/gpt-engineer/blob/main/docker/README.md does not have text editors and breaking gpte in the -i (improve) mode.
This fixes #1200 and provides a choice between two text editors vim and nano that can be made with -e EDITOR env variable during docker run. Nano will be used by default.
Important
Adds
vimandnanoto Docker container, allowing editor choice via-e EDITORenv variable, defaulting tonano.vimandnanoto the Docker container indocker/Dockerfile.-imode ingpteby providing text editors.-e EDITORenvironment variable during Docker run, defaulting tonano.This description was created by
for 5831bb3. It will automatically update as commits are pushed.