old fields shouldn't be in the app dataclass

Author: enyst

tests/unit/test_config.py

@@ -125,6 +125,9 @@ def test_load_from_new_style_toml(default_config, temp_toml_file):
     assert default_config.sandbox.box_type == 'local'
     assert default_config.sandbox.timeout == 1
 
+    # default config doesn't have a field sandbox_type
+    assert not hasattr(default_config, 'sandbox_type')
+
     # before finalize_config, workspace_mount_path is UndefinedString.UNDEFINED if it was not set
     assert default_config.workspace_mount_path is UndefinedString.UNDEFINED
     assert (
@@ -175,6 +178,12 @@ def test_compat_load_sandbox_from_toml(default_config, temp_toml_file):
 
     finalize_config(default_config)
 
+    # app config doesn't have fields sandbox_*
+    assert not hasattr(default_config, 'sandbox_type')
+    assert not hasattr(default_config, 'sandbox_timeout')
+    assert not hasattr(default_config, 'sandbox_container_image')
+    assert not hasattr(default_config, 'sandbox_user_id')
+
     # after finalize_config, workspace_mount_path is set to the absolute path of workspace_base
     # if it was undefined
     assert default_config.workspace_mount_path == '/opt/files2/workspace'