Fix missing None-check in get_conversations (#8927)

Author: raymyers

openhands/server/conversation_manager/standalone_conversation_manager.py

@@ -111,7 +111,8 @@ async def attach_to_conversation(
                 return None
             end_time = time.time()
             logger.info(
-                f'ServerConversation {c.sid} connected in {end_time - start_time} seconds'
+                f'ServerConversation {c.sid} connected in {end_time - start_time} seconds',
+                extra={'session_id': sid}
             )
             self._active_conversations[sid] = (c, 1)
             return c

openhands/server/routes/conversation.py

@@ -145,5 +145,5 @@ async def search_events(
 @app.post('/events')
 async def add_event(request: Request, conversation: ServerConversation = Depends(get_conversation)):
     data = request.json()
-    conversation_manager.send_to_event_stream(conversation.sid, data)
+    await conversation_manager.send_to_event_stream(conversation.sid, data)
     return JSONResponse({'success': True})

openhands/server/utils.py

@@ -1,5 +1,6 @@
-from fastapi import Depends, Request
+from fastapi import Depends, HTTPException, Request, status
 
+from openhands.core.logger import openhands_logger as logger
 from openhands.server.shared import ConversationStoreImpl, config, conversation_manager
 from openhands.server.user_auth import get_user_auth, get_user_id
 from openhands.storage.conversation.conversation_store import ConversationStore
@@ -25,6 +26,15 @@ async def get_conversation(
     conversation = await conversation_manager.attach_to_conversation(
         conversation_id, user_id
     )
+    if not conversation:
+        logger.warn(
+            f'get_conversation: conversation {conversation_id} not found, attach_to_conversation returned None',
+            extra={'session_id': conversation_id, 'user_id': user_id},
+        )
+        raise HTTPException(
+            status_code=status.HTTP_404_NOT_FOUND,
+            detail=f'Conversation {conversation_id} not found',
+        )
     try:
         yield conversation
     finally: