Skip to content

[white-labelling] The build system needs 64px and 16px icons #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davesag opened this issue Jun 3, 2020 · 0 comments
Open

[white-labelling] The build system needs 64px and 16px icons #6

davesag opened this issue Jun 3, 2020 · 0 comments
Labels
enhancement New feature or request white-labelling Issue relates to allowing 3rd parties to create their own versions of this browser extension

Comments

@davesag
Copy link
Contributor

davesag commented Jun 3, 2020

The build system assumes the presence of 64px and 16px icons, though they're not required by the browsers. The build system puts references to each of those in the generated manifest.json, but if they are not present the browser throws an error.

  1. Browsers don't use the 64px rendition at all

  2. The build system should either

    (a) check if the lower-res renditions exist on the assets path or
    (b) add a setting to build-config to list which renditions should be referenced in the generated manifest.json.

@davesag davesag added enhancement New feature or request white-labelling Issue relates to allowing 3rd parties to create their own versions of this browser extension labels Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request white-labelling Issue relates to allowing 3rd parties to create their own versions of this browser extension
Projects
None yet
Development

No branches or pull requests

1 participant