Skip to content

[BUG] extraneous information in ad markup #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeremybmerrill opened this issue Jul 14, 2020 · 0 comments
Open

[BUG] extraneous information in ad markup #20

jeremybmerrill opened this issue Jul 14, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@jeremybmerrill
Copy link
Collaborator

Describe the bug
Related to #17, the markup of the ad that's sent to the server contains extraneous information.

To Reproduce
Steps to reproduce the behavior:

  1. Follow steps from 17.
  2. Examine HTML in items[0].payload.adTargetingHtml; ctrl-F for likes.

Expected behavior
We should include only the ad itself.

Additional context

I think the problem is solvable by treating the innermost .userContentWrapper as the ad markup. (Or, at least, only sending that.) That's what we've done in the old extension. I suspect this excludes stuff like FB's "Coronavirus Information" banner too. Haven't checked and I'm not sure if that's good or not.

@jeremybmerrill jeremybmerrill added the bug Something isn't working label Jul 14, 2020
@jeremybmerrill jeremybmerrill changed the title [BUG] [BUG] extraneous information in ad markup Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant