Skip to content

Commit 1c9e3a8

Browse files
committed
fix: Bump pre-commit hooks to fix isort issue
CI is broken on main due to this isort issue, the root cause lies in an underlying incompatible change in Poetry. PyCQA/isort#2083 With the upgrade to flake8 6, we ran into an issue with comments in the configuration file. Those comments are moved to their own lines above the config instead, see issue below. PyCQA/flake8#1756
1 parent 765ccd9 commit 1c9e3a8

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

.flake8

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,12 @@ max-line-length = 125
33

44
# E203,W503: incompatibilities with black
55
# E722: also signaled by pylint (disabling here globally and on case-by-case basis with pylint)
6+
# E501: line length
7+
# E203: whitespace before ':'
8+
# W503: line break before binary operator
9+
# E722: do not use bare 'except'
610
ignore =
7-
E501, # line length
8-
E203, # whitespace before ':'
9-
W503, # line break before binary operator
10-
E722, # do not use bare 'except'
11+
E501,
12+
E203,
13+
W503,
14+
E722,

.pre-commit-config.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
minimum_pre_commit_version: 2.9.2
33
repos:
44
- repo: https://github.com/pre-commit/pre-commit-hooks
5-
rev: v4.1.0
5+
rev: v4.4.0
66
hooks:
77
- id: trailing-whitespace
88
exclude: ^vendor/|^tests/.*/fixtures/.*|^tests/integration/test_data/.*
@@ -11,18 +11,18 @@ repos:
1111
- id: debug-statements
1212

1313
- repo: https://github.com/PyCQA/isort
14-
rev: 5.10.1
14+
rev: 5.12.0
1515
hooks:
1616
- id: isort
1717
name: isort (python)
1818

1919
- repo: https://github.com/psf/black
20-
rev: 22.3.0
20+
rev: 22.12.0
2121
hooks:
2222
- id: black
2323

2424
- repo: https://github.com/PyCQA/flake8
25-
rev: 4.0.1
25+
rev: 6.0.0
2626
hooks:
2727
- id: flake8
2828

0 commit comments

Comments
 (0)