fix: load configuration with WS-federation options

closes #98

Author: github-actions

src/Aguacongas.AspNetCore.Authentication/AuthenticationSchemeOptionsSerializer.cs

@@ -26,7 +26,7 @@ public class AuthenticationSchemeOptionsSerializer : IAuthenticationSchemeOption
             NullValueHandling = NullValueHandling.Ignore,
             ReferenceLoopHandling = ReferenceLoopHandling.Ignore,
             Formatting = Formatting.None,
-            DefaultValueHandling = DefaultValueHandling.Ignore,
+            DefaultValueHandling = DefaultValueHandling.Include,
             ContractResolver = new ContractResolver()
         };
 

test/Aguacongas.AspNetCore.Authentication.Test/ApplicationBuilderExtensionsTest.cs

@@ -0,0 +1,54 @@
+using Microsoft.AspNetCore.Authentication.WsFederation;
+using Microsoft.AspNetCore.Builder;
+using Microsoft.Extensions.DependencyInjection;
+using Moq;
+using System.Collections.Generic;
+using System.Linq;
+using Xunit;
+
+namespace Aguacongas.AspNetCore.Authentication.Test
+{
+    public class ApplicationBuilderExtensionsTest
+    {
+        [Fact]
+        public void LoadDynamicAuthenticationConfiguration_should_load_WsFederationOptions()
+        {
+            var serializer = new AuthenticationSchemeOptionsSerializer();
+            var serialized = serializer.SerializeOptions(new WsFederationOptions
+            {
+                RequireHttpsMetadata = false,
+                MetadataAddress = "http://localhost:5000/wsfederation",
+                Wtrealm = "urm:aspnetcorerp"
+            }, typeof(WsFederationOptions));
+            var storeMock = new Mock<IDynamicProviderStore<SchemeDefinition>>();
+            storeMock.Setup(m => m.SchemeDefinitions).Returns(new List<string>
+            {
+                serialized
+            }.Select(s => new SchemeDefinition
+            {
+                DisplayName = "test",
+                HandlerType = typeof(WsFederationHandler),
+                Options = serializer.DeserializeOptions(s, typeof(WsFederationOptions)),
+                Scheme = "test"
+            }).AsQueryable());
+            var services = new ServiceCollection().AddTransient(p => storeMock.Object);
+
+            services.AddAuthentication()
+                .AddDynamic<SchemeDefinition>()
+                .AddWsFederation();
+
+            var provider = services.BuildServiceProvider();
+            var applicationBuilderMock = new Mock<IApplicationBuilder>();
+            applicationBuilderMock.SetupGet(m => m.ApplicationServices).Returns(provider);
+
+            applicationBuilderMock.Object.LoadDynamicAuthenticationConfiguration<SchemeDefinition>();
+
+            Assert.True(true);
+        }
+
+        public class SchemeDefinition : SchemeDefinitionBase
+        {
+
+        }
+    }
+}

test/Aguacongas.AspNetCore.Authentication.Test/AuthenticationSchemeOptionsSerializerTest.cs

@@ -38,5 +38,21 @@ public void DeserializeOptions_should_deserialize_WsFederationOptions()
 
             Assert.False(result.RequireHttpsMetadata);
         }
+
+        [Fact]
+        public void SeserializeOptions_should_seserialize_default_value()
+        {
+            var sut = new AuthenticationSchemeOptionsSerializer();
+            var result = sut.SerializeOptions(new WsFederationOptions
+            {
+                RequireHttpsMetadata = false
+            }, typeof(WsFederationOptions));
+
+            Assert.Contains(nameof(WsFederationOptions.RequireHttpsMetadata), result);
+
+            var deserialized = sut.DeserializeOptions(result, typeof(WsFederationOptions)) as WsFederationOptions;
+
+            Assert.False(deserialized.RequireHttpsMetadata);
+        }
     }
 }

test/Aguacongas.AspNetCore.Authentication.Test/DynamicManagerTest.cs

@@ -55,6 +55,7 @@ public async Task Assertions()
             await Assert.ThrowsAsync<ArgumentException>(() => manager.FindBySchemeAsync(""));
             await Assert.ThrowsAsync<ArgumentException>(() => manager.FindBySchemeAsync("  "));
         }
+
     }
     public class FakeSchemeDefinition : SchemeDefinitionBase
     { }