Skip to content

Commit f91b395

Browse files
mergify[bot]gibson042
authored andcommitted
fix: Disallow Node.js major version >20 (#9630)
refs: #9622 ## Description #9623 claimed to enforce Node.js versions ^18.12 or ^20.9, but due to a typo allows arbitrarily high versions to pass the check. This corrects it to enforce that the major version is exactly 18 or 20. ### Security Considerations None. ### Scaling Considerations n/a ### Documentation Considerations Matches the [README](https://github.com/Agoric/agoric-sdk?tab=readme-ov-file#prerequisites). ### Testing Considerations Checked by integration testing in CI. ### Upgrade Considerations Will need an update for supporting Node.js v22 when that enters LTS (ref #9265).
2 parents b0f1f66 + 972dd6f commit f91b395

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

repoconfig.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ golang_version_check() {
2020
nodejs_version_check() {
2121
{
2222
[ "$1" -eq 18 ] && [ "$2" -ge 12 ] && return 0
23-
[ "$1" -ge 20 ] && [ "$2" -ge 9 ] && return 0
23+
[ "$1" -eq 20 ] && [ "$2" -ge 9 ] && return 0
2424
} 2> /dev/null
2525
echo 1>&2 "need Node.js LTS version ^18.12 or ^20.9, found $1.$2.$3"
2626
return 1

0 commit comments

Comments
 (0)