Skip to content

Commit dd26503

Browse files
matthewlanejsnellbaker
authored andcommitted
Fix event firing on native click (prebid#3589)
1 parent 5112950 commit dd26503

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

src/native.js

+1
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,7 @@ export function fireNativeTrackers(message, adObject) {
144144
}
145145

146146
(trackers || []).forEach(triggerPixel);
147+
return message.action;
147148
}
148149

149150
/**

src/secureCreatives.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,9 @@ function receiveMessage(ev) {
5252
return;
5353
}
5454

55-
fireNativeTrackers(data, adObject);
55+
const trackerType = fireNativeTrackers(data, adObject);
56+
if (trackerType === 'click') { return; }
57+
5658
auctionManager.addWinningBid(adObject);
5759
events.emit(BID_WON, adObject);
5860
}

test/spec/native_spec.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,8 @@ describe('native.js', function () {
8585
});
8686

8787
it('fires click trackers', function () {
88-
fireNativeTrackers({ action: 'click' }, bid);
88+
const trackerType = fireNativeTrackers({ action: 'click' }, bid);
89+
expect(trackerType).to.equal('click');
8990
sinon.assert.calledOnce(triggerPixelStub);
9091
sinon.assert.calledWith(triggerPixelStub, bid.native.clickTrackers[0]);
9192
});

0 commit comments

Comments
 (0)