Skip to content

Commit 5bd6d47

Browse files
committed
'currency' isn't a bidder-specific param
Update PR following this remark on another one: prebid#3228 (comment)
1 parent 50b8e37 commit 5bd6d47

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

modules/adikteevBidAdapter.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import {registerBidder} from 'src/adapters/bidderFactory';
22
import {BANNER} from 'src/mediaTypes';
33
import * as utils from '../src/utils';
4+
import {config} from 'src/config';
45

56
export const BIDDER_CODE = 'adikteev';
67
export const ENDPOINT_URL = 'https://serve-adserver.adikteev.com/api/prebid/bid';
@@ -32,8 +33,6 @@ export const spec = {
3233
return !!(
3334
bid &&
3435
bid.params &&
35-
bid.params.currency &&
36-
bid.params.currency === 'EUR' &&
3736
bid.params.bidFloorPrice &&
3837
bid.params.placementId &&
3938
bid.bidder === BIDDER_CODE &&
@@ -45,7 +44,8 @@ export const spec = {
4544
const payload = {
4645
validBidRequests,
4746
bidderRequest,
48-
referrerInfo: bidderRequest.refererInfo,
47+
refererInfo: bidderRequest.refererInfo,
48+
currency: config.getConfig('currency'),
4949
userAgent: navigator.userAgent,
5050
screen: {
5151
width: window.screen.width,

modules/adikteevBidAdapter.md

-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ Module that connects to Adikteev's demand sources
2626
bidder: 'adikteev',
2727
params: {
2828
placementId: 12345,
29-
currency: 'EUR',
3029
bidFloorPrice: 0.1,
3130
}
3231
}

test/spec/modules/adikteevBidAdapter_spec.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ describe('adikteevBidAdapter', () => {
3434
bidder: 'adikteev',
3535
params: {
3636
placementId: 12345,
37-
currency: 'EUR',
3837
bidFloorPrice: 0.1,
3938
},
4039
mediaTypes: {
@@ -62,7 +61,6 @@ describe('adikteevBidAdapter', () => {
6261
bidder: '', // invalid bidder
6362
params: {
6463
placementId: 12345,
65-
currency: 'EUR',
6664
bidFloorPrice: 0.1,
6765
},
6866
mediaTypes: {
@@ -75,7 +73,6 @@ describe('adikteevBidAdapter', () => {
7573
bidder: 'adikteev',
7674
params: {
7775
placementId: '', // invalid placementId
78-
currency: 'EUR',
7976
bidFloorPrice: 0.1,
8077
},
8178
mediaTypes: {
@@ -88,7 +85,6 @@ describe('adikteevBidAdapter', () => {
8885
bidder: 'adikteev',
8986
params: {
9087
placementId: 12345,
91-
currency: 'EUR',
9288
bidFloorPrice: 0.1,
9389
},
9490
mediaTypes: {
@@ -121,6 +117,8 @@ describe('adikteevBidAdapter', () => {
121117
'screen',
122118
'language',
123119
'cookies',
120+
// 'refererInfo',
121+
// 'currency',
124122
'prebidUpdateVersion',
125123
);
126124
expect(requestData.validBidRequests).to.deep.equal(validBidRequests);

0 commit comments

Comments
 (0)