Skip to content

Adapt cebra.save and cebra.load functions for upcoming torch.load changes #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
stes opened this issue Jan 22, 2025 · 1 comment
Closed
2 tasks done
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@stes
Copy link
Member

stes commented Jan 22, 2025

Due to an upcoming change in pytorch, we need to make the cebra.save function future proof:

cebra/integrations/sklearn/cebra.py:1453: FutureWarning: You are using `torch.load` with `weights_only=False` (the current default value), which uses the default pickle module implicitly. It is possible to construct malicious pickle data which will execute arbitrary code during unpickling (See https://github.com/pytorch/pytorch/blob/main/SECURITY.md#untrusted-models for more details). In a future release, the default value for `weights_only` will be flipped to `True`. This limits the functions that could be executed during unpickling. Arbitrary objects will no longer be allowed to be loaded via this mode unless they are explicitly allowlisted by the user via `torch.serialization.add_safe_globals`. We recommend you start setting `weights_only=True` for any use case where you don't have full control of the loaded file. Please open an issue on GitHub for any issues related to this experimental feature.
    checkpoint = torch.load(filename, **kwargs)

Steps to implement:

  • Specify torch.serialization.add_safe_globals in cebra.save
  • Add a test checking for the current warning (should fail with current codebase) -> update and fix text
@stes stes added enhancement New feature or request good first issue Good for newcomers labels Jan 22, 2025
@stes stes changed the title Improve cebra.save and cebra.load functions Adapt cebra.save and cebra.load functions for upcoming torch.load changes Jan 22, 2025
@stes
Copy link
Member Author

stes commented Feb 2, 2025

Fixed with #221

@stes stes closed this as completed Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant